-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New arch] Pattern activity #3389
Conversation
b745e6e
to
2e65dce
Compare
928bec6
to
0207636
Compare
d155620
to
b638136
Compare
0207636
to
d5623c0
Compare
b638136
to
32aeb17
Compare
d5623c0
to
a34fef5
Compare
8190a69
to
e92ebff
Compare
…y instead of BaseActivity unnecessarily
a2c0f2b
to
c2ab5d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic job @JuancaG05 ! 👍
I added some suggestions here
owncloudApp/src/androidTest/java/com/owncloud/android/settings/security/PatternActivityTest.kt
Outdated
Show resolved
Hide resolved
.../src/test/java/com/owncloud/android/presentation/viewmodels/security/PatternViewModelTest.kt
Show resolved
Hide resolved
...ain/java/com/owncloud/android/presentation/ui/settings/fragments/SettingsSecurityFragment.kt
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/security/PatternActivity.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/security/PatternActivity.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/security/PatternActivity.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/security/BiometricActivity.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @JuancaG05, Let's move to QA
owncloudApp/src/androidTest/java/com/owncloud/android/settings/security/PatternActivityTest.kt
Outdated
Show resolved
Hide resolved
SonarCloud Quality Gate failed. 710 Bugs |
Approved. |
Related Issues
App: #3373
QA
Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.20/3389-pattern_lock_architecture.md
Reports: