Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New arch] Pattern activity #3389

Merged
merged 27 commits into from
Nov 16, 2021
Merged

[New arch] Pattern activity #3389

merged 27 commits into from
Nov 16, 2021

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Sep 21, 2021

@JuancaG05 JuancaG05 self-assigned this Sep 21, 2021
@JuancaG05 JuancaG05 marked this pull request as draft September 21, 2021 07:19
@JuancaG05 JuancaG05 linked an issue Sep 21, 2021 that may be closed by this pull request
14 tasks
@JuancaG05 JuancaG05 force-pushed the new_arch/pattern branch 2 times, most recently from 928bec6 to 0207636 Compare September 27, 2021 10:26
@JuancaG05 JuancaG05 marked this pull request as ready for review September 27, 2021 11:32
@JuancaG05 JuancaG05 requested review from abelgardep and fesave and removed request for abelgardep September 27, 2021 11:32
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job @JuancaG05 ! 👍

I added some suggestions here

@abelgardep abelgardep mentioned this pull request Oct 5, 2021
12 tasks
@JuancaG05 JuancaG05 requested a review from abelgardep October 7, 2021 10:44
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @JuancaG05, Let's move to QA

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2021

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 10, 2021

Approved.

@JuancaG05 JuancaG05 merged commit 8d79657 into feature/lock_delay Nov 16, 2021
@JuancaG05 JuancaG05 deleted the new_arch/pattern branch November 16, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New arch] Pattern activity
3 participants