Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Brute force protection #3320

Closed
14 tasks done
jesmrec opened this issue Jul 21, 2021 · 2 comments · Fixed by #3463
Closed
14 tasks done

[FEATURE REQUEST] Brute force protection #3320

jesmrec opened this issue Jul 21, 2021 · 2 comments · Fixed by #3463

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 21, 2021

Actually, app is protected via passcode (and other methods). Our current passcode is 4-digit, so 10000 different passcode exist. Someone with enough time could try all the posibilities to unlock the app.

In order to avoid such situation, we should protect the passcode against brute force.

how does iOS do?

  • You have three attempts to enter the correct passcode
  • If not, you will have to wait some seconds for a new attemp
  • If not, you will have to wait more seconds
  • If not, more time etc etc...

Exponential increment of the time to wait for a new attempt.

this is a very common mechanism. There are also apps that block the access during some time if the initial 3 attempts fail...

more inputs and approaches are welcome.

TASKS

  • Research (if needed)
  • Create branch feature/brute_force
  • Development tasks
    • Use ViewBinding instead of findViewById in PassCodeActivity
    • Create a preference with the number of attempts
    • Lock the app in function of the number of attempts
    • Show the countdown in the passcode screen
    • Take into account that the app can be closed and the countdown timer shouldn't start again
    • Unit tests
    • UI tests
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/brute_force into master

PR

  • App
  • Library (if needed)
@michaelstingl
Copy link
Contributor

In order to avoid such situation, we should protect the passcode against brute force.

Yeah, now with Scoped Storage it's really useful 👍 .

@jesmrec jesmrec added this to the 2.20-next milestone Aug 20, 2021
@fesave fesave self-assigned this Nov 9, 2021
@fesave
Copy link
Contributor

fesave commented Nov 9, 2021

Blocked until #3375 , #3384 and #3389 have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants