Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Lock delay for app #3375

Merged
merged 42 commits into from
Nov 18, 2021
Merged

[FEATURE REQUEST] Lock delay for app #3375

merged 42 commits into from
Nov 18, 2021

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Sep 10, 2021

Related Issues

App: #3344

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

Test Plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.20/3375-lock_delaymd.md

Reports:

@JuancaG05 JuancaG05 self-assigned this Sep 10, 2021
@JuancaG05 JuancaG05 linked an issue Sep 10, 2021 that may be closed by this pull request
12 tasks
@JuancaG05 JuancaG05 changed the base branch from master to new_arch/passcode September 10, 2021 09:21
@JuancaG05 JuancaG05 changed the title [FEATURE REQUEST] Lock delay for app and document provider [FEATURE REQUEST] Lock delay for app Sep 14, 2021
@JuancaG05 JuancaG05 marked this pull request as ready for review September 15, 2021 07:48
Base automatically changed from new_arch/passcode to master September 16, 2021 07:26
@JuancaG05 JuancaG05 requested a review from fesave September 16, 2021 09:08
Copy link
Contributor

@fesave fesave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions here @JuancaG05

@JuancaG05
Copy link
Collaborator Author

@abelgardep changes performed, ready to re-review!

@JuancaG05 JuancaG05 force-pushed the feature/lock_delay branch 3 times, most recently from 8190a69 to e92ebff Compare October 1, 2021 06:43
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 10, 2021

(1) [FIXED]

A question: why is the default value Not Set when the behaviour is the same as Immediately? Does it make sense to set as default Immediately?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JuancaG05 JuancaG05 merged commit ab60371 into master Nov 18, 2021
@JuancaG05 JuancaG05 deleted the feature/lock_delay branch November 18, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Lock delay for app
4 participants