-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Lock delay for app #3375
Conversation
793f51b
to
31a40d9
Compare
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/security/PassCodeActivity.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/security/PassCodeActivity.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/security/PassCodeActivity.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
963c4cc
to
c783272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions here @JuancaG05
...ain/java/com/owncloud/android/presentation/ui/settings/fragments/SettingsSecurityFragment.kt
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/security/SecurityUtils.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/authentication/BiometricManager.java
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/authentication/PatternManager.java
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/authentication/PatternManager.java
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/security/PassCodeManager.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/security/SecurityUtils.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt
Show resolved
Hide resolved
@abelgardep changes performed, ready to re-review! |
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/security/SecurityUtils.kt
Outdated
Show resolved
Hide resolved
b745e6e
to
2e65dce
Compare
owncloudApp/src/main/java/com/owncloud/android/ui/activity/BiometricActivity.java
Outdated
Show resolved
Hide resolved
8190a69
to
e92ebff
Compare
Kudos, SonarCloud Quality Gate passed! |
(1) [FIXED]A question: why is the default value |
9687768
to
898fc9b
Compare
Kudos, SonarCloud Quality Gate passed! |
Related Issues
App: #3344
QA
Test Plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.20/3375-lock_delaymd.md
Reports: