Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New arch] Biometric activity #3377

Closed
9 of 12 tasks
JuancaG05 opened this issue Sep 13, 2021 · 2 comments · Fixed by #3395
Closed
9 of 12 tasks

[New arch] Biometric activity #3377

JuancaG05 opened this issue Sep 13, 2021 · 2 comments · Fixed by #3395
Assignees
@JuancaG05
Labels
Estimation - 3 (M) New architecture
Milestone
2.20

Comments

@JuancaG05
Copy link
Collaborator

JuancaG05 commented Sep 13, 2021 •
edited
Loading

Biometric activity is written in Java in the old architecture. The aim of this issue is to move the biometric activity and all its related stuff to presentation.ui.security package and rewrite the class in Kotlin.

TASKS

  • Create branch new_arch/biometric
  • Development tasks
    • Move all the classes to presentation.ui.security package
    • Kotlinize BiometricActivity
    • Create new BiometricViewModel
    • Move logic from BiometricActivity to BiometricViewModel
    • Kotlinize BiometricManager
    • Include unit tests
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch new_arch/biometric into master
@JuancaG05 JuancaG05 added this to the 2.20-next milestone Sep 13, 2021
@JuancaG05 JuancaG05 self-assigned this Sep 13, 2021
@abelgardep
Copy link
Contributor

It would be great if you could bump the biometric dependency from 1.0.1 to 1.1.0

I'm not sure whether it requires so many changes

@JuancaG05 JuancaG05 mentioned this issue Sep 29, 2021
Merged
@JuancaG05 JuancaG05 linked a pull request Sep 29, 2021 that will close this issue
[New arch] Biometric activity #3395
Merged
@jesmrec jesmrec removed the Sprint label Oct 1, 2021
@abelgardep
Copy link
Contributor

It will be tested within #3389

Great job @JuancaG05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuancaG05 JuancaG05

Labels
Estimation - 3 (M) New architecture
Projects
None yet
Milestone
2.20
Development

Successfully merging a pull request may close this issue.

[New arch] Biometric activity owncloud/android
3 participants
@jesmrec @abelgardep @JuancaG05