[FIX] Oval Shape button to a Circle in the What's New screen section

[sashpawar11]

Related Issues

App: #3351

Changed the previous oval shape to what it was intended to be, a Circular round button on the What's New Activity Screen after it reaches the final screen.
Attached screenshot below.

---

[CLAassistant]

All committers have signed the CLA.

[abelgardep]

Thanks for the contribution @sashpawar11 !! we will take care of it soon 👍

[JuancaG05]

Thanks a lot for your contribution @sashpawar11! Please take a look at this other XML file, it's the same layout you modified but for other screen resolution. If you could test it in some bigger device and see if it needs changes, it would be great and very complete! 👍

[sashpawar11]

Thanks a lot for your contribution @sashpawar11! Please take a look at this other XML file, it's the same layout you modified but for other screen resolution. If you could test it in some bigger device and see if it needs changes, it would be great and very complete! 👍

Sure, I'll test it out

[abelgardep]

Hi @sashpawar11, I have checked it with some devices with different screen sizes. 64dp is too big for smaller devices like Nexus S. BTW, this activity has 2 layouts, as @JuancaG05 stated here, and we need to update the other one too because it is used for bigger devices like Nexus 10, which still shows an oval.

Nexus S	Nexus 10

A first solution could be reducing the size from 64dp to 48dp in https://github.com/owncloud/android/blob/master/owncloudApp/src/main/res/layout/whats_new_activity.xml and add 64dp in https://github.com/owncloud/android/blob/master/owncloudApp/src/main/res/layout-sw600dp/whats_new_activity.xml

Just some changes and we will move it forward 👍

[sashpawar11]

Thanks a lot for that @abelgardep! I'll do the changes immediately

[sashpawar11]

Made the changes @JuancaG05 @abelgardep ! Tested it on both Small and Large screens, works absolutely fine.

NexusS:

Nexus 10:

[JuancaG05]

Great!! Thanks a lot again for your contribution @sashpawar11!! See you!! 🥳

[abelgardep]

Checked with different devices:

Nexus S
Nexus 5X
Pixel 3XL
Nexus 10

LGTM, thanks for the contribution @sashpawar11