[BUG] Button in Welcome Wizard is oval

[tbsbdr]

Actual behaviour

• At the end of the welcome-wizard, the button is oval
  

Expected behaviour

• button should be round i guess ;-)

Steps to reproduce

1. fresh install of the app
2. step till the last panel
3. button is oval

Environment data

Android version: Android 12 Beta

Device model: Pixel 3

Stock or customized system: stock

ownCloud app version: 2.18.1

[abelgardep]

I think that the button is oval since the beginning. Anyway, we could update it to a round shape 👍

[tbsbdr]

not important, but would make me really happy ;-)
nice to have...

[sashpawar11]

Can you assign this to me? I would love to work on it.

[abelgardep]

Hey @sashpawar11, feel free to send a PR 💯

I could help you in case you have any questions 👍

[sashpawar11]

Cool, thanks @abelgardep !

[sashpawar11]

Hey @sashpawar11, feel free to send a PR 💯

I could help you in case you have any questions 👍

Hey I'm unable to find the exact activity for the above screen, could you help me out?

[abelgardep]

It's WhatsNewActivity and in this method the arrow is replaced with the done icon. So the problem could be in the done icon

[sashpawar11]

Yep thanks @abelgardep , fixed it, ill make a PR soon

[sashpawar11]

So i made the shape as a round Circle which was an oval before but, how do I test the app? It asks for server address on the startscreen and I don't have one, is there a test IP or anything so I can just try to reach the above screen quickly? @abelgardep

[michaelstingl]

is there a test IP or anything

You can test-drive with demo.owncloud.com

[abelgardep]

Well, you won't need to add any server because that screen appears just after performing a fresh installment when we are on release mode.

In the shouldShow function we determine if the wizard needs to be shown or not. Just for testing, you can make it return true, and the wizard will appear when the app starts. This change in the shouldShow is just for testing. Do not send it in the PR!

If you need something else, feel free to ask @sashpawar11 👍

[sashpawar11]

Well, you won't need to add any server because that screen appears just after performing a fresh installment when we are on release mode.

In the shouldShow function we determine if the wizard needs to be shown or not. Just for testing, you can make it return true, and the wizard will appear when the app starts. This change in the shouldShow is just for testing. Do not send it in the PR!

If you need something else, feel free to ask @sashpawar11 👍

Cool got it! Thanks a lot , again! @abelgardep