[RELEASE] 2.19

[jesmrec]

TASKS:

• [GIT] Create branch release/1.0.13 in owncloud/android-library from master
• [GIT] Create branch release/2.19 in owncloud/android from master
• [DEV] Update version number and name in build.gradle in owncloudComLibrary module
• [DEV] Update version number and name in build.gradle in owncloudApp module
• [DIS] Create a folder for the new version like 2.19.0_YYYY-MM-DD
• [DIS] Move all changelog files from the unreleased folder to the new version folder
• [DIS] Update screenshots, if needed, in README.md
• [QA] Design Test plan
• [QA] Regression Test plan
• [QA] Test pending stuff with Scoped Storage -> clean old user directories #3336 (comment)
• [DIS] Generate test bundle from release/2.19 branch in owncloud/android
• [GIT] Create and sign tag 'oc-android-2.19' in HEAD commit of release branch, in owncloud/android
• [GIT] Create and sign tag '1.0.13' in HEAD commit of release branch, in owncloud/android-library
• [DIS] Generate final bundle from signed commit in owncloud/android
• [COM] Inform #release_coordination and #marketing in internal chat
• [GIT] Merge branch release/1.0.13 in owncloud/android-library, into master
• [GIT] Merge branch release/2.19 in owncloud/android, into master
• [DIS] Upload & publish release bundle and changelog in Play Store
• [DIS] Update screenshots and store listing, if needed, in Play Store
• [GIT] Publish a new release in owncloud/android
• [DIS] Upload release APK and bundle to internal owncloud instance
• [GIT] Merge master branch into stable, in owncloud/android-library
• [GIT] Merge master branch into stable, in owncloud/android
• [DOC] Update owncloud.org/download version numbers (notify rocketchat #marketing)

---

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.19/Regression%202.19.md

BUGS & IMPROVEMENTS:

• App leads to ANR after removing account if there were too many downloaded files #3362 (regression)
• (1) Change wording in wizard [RELEASE] 2.19 #3325 (comment) [DONE]
• (2) Progress bar in wizard [RELEASE] 2.19 #3325 (comment) [WONT FIX]
• (3) More section can be empty [RELEASE] 2.19 #3325 (comment) [FIXED]
• (4) Button is cut off in welcome wizard [RELEASE] 2.19 #3325 (comment). [FIXED]
• (5) Logs collected with option disabled [RELEASE] 2.19 #3325 (comment) [FIXED]
• (6) Leftovers when migration is done when file is copied to /tmp [RELEASE] 2.19 #3325 (comment) [FIXED]
• (7) Migration with reduced space [RELEASE] 2.19 #3325 (comment) [FIXED]

PR

App: #3436
Library: owncloud/android-library#441

[jesmrec]

(1) [DONE]

Scoped Storage Wizard: in the last slide, using Access your files instead of Close

[jesmrec]

(2) [WONT DO IT]

Scoped Storage Wizard: check if adding a meaningful progress bar is feasible

[jesmrec]

(3) [FIXED]

1. Set the following values in setup.xml:

    <bool name="help_enabled">false</bool>
    <bool name="sync_calendar_contacts_enabled">false</bool>
    <bool name="imprint_enabled">false</bool>
    <bool name="recommend_enabled">false</bool>
    <bool name="feedback_enabled">false</bool>

2. Open the app > Settings > More

Current: Empty

Expected: More section is hidden because al its content is hidden. After moving the privacy policy link from there, it should be removed from the More visibility condition as well

Pixel2 Android11
214c3800c

[jesmrec]

(4) [FIXED]

This one comes from #3351

In landscape mode, the new button is cut off:

Pixel2 Android11
214c3800

[jesmrec]

(5) [FIXED]

1. Go to Settings > Logging > Enable Logging
2. Perform some actions in the app, so that the log file will have content
3. Go to Settings > Log files and remember the log file size
4. Disable Logging
5. Perform more actions in the app
6. Go to Settings > Log files and check the log file size

Current: file size in 6. is higher that in 3. That means that logs are being collected.

Expected: file size in 6. should be the same as in 3. Logs are disabled, so no new logs should be collected

Pixel2 Android11
214c3800

[jesmrec]

(6) [FIXED]

Check this scenario out:

1. Select a big file with oC, using the sharing sheet
2. While the file is being copied to /tmp before performing the upload, migration is executed

Current: /tmp folder is copied to scoped storage, including part of the copied file that was interrupted by the migration. But, the primary action (share with oC) is not resumed.

Things to consider:

• Is it correct that such action or other similars (pending to copy local files to owncloud) are not done as uploads?
• Any way to wipe the lost piece of files?

Pixel2 Android11
214c3800

[jesmrec]

about (6), three cases checked:

• Sharing a big file + migration = tmp clean
• Sharing a big file + uploads ongoing = tmp with uploads + tmp with no shared file fragments
• Sharing a files + upload in different accounts + migration = uploads OK + tmp cleaned of pending shares

[jesmrec]

(7) [FIXED]

I stumbled upon this problem, similar to one we faced some days ago

With 9 GB space free in device:

1. Install 2.18.3
2. Download a file of 5GB and 5 files of 100MB (~5.5 GB) -> ~4.5GB left in device
3. Migration

Current: Migration ends but nothing is downloaded

Expected: All 100MB files are dowloaded. 5GB file is not dowloaded because there is no space left to copy it

fec4585e
Nexus 6P v7

[jesmrec]

Release 2.19 is approved and ready to go:

Approved commits:

• App: c1ea0594
• Library: 20efe90e
• IDE version (Android Studio): Arctic Fox 2020.3.1 Patch 1
• Devices: Pixel2 (Android11), Nexus 6 (Android7), Huawei P20L (Android9)
• E2E tests report:
  2.19.zip
  scenarios

Other comments:

• About Scoped Storage migration:

  • If migration happens meanwhile an upload is running, upload stops and stays in the uploads view. It will have to be retried manually in the uploads view by using the retrying actions. At the end, file is pushed to the server and local copy exists inside the scoped storage.

  • If migration happens meanwhile a file is being shared with oC before starting the upload, it will not be retried, and it will be cleaned up from temporary internal folder. Sharing action will have to be done again after the updating process. For this reason, is totally recommended not to have pending actions like this one just before doing this update. Recommended to forward this to customers.

  • Files are migrated from legacy storage to scoped storage one by one. Once one file is copied to the scoped storage, then is removed from legacy storage. That means, if the free space in the device is less than a file size, this file will not be migrated. It will have to be downloaded again manually by the user, once the device has enough free space to host it.

  • We were suggested to replace the flashing bar for a progress bar that shows the user the current % of migration done and left (check report (2)). We discard this option because the migration process is the sum of different subprocesses (not only copying files). We can not control all of them in the same progress bar without including an extra complexity that leads to extra testing. Given the migration does not take very long (Pixel2 of 2017 takes less than 2 minutes to move 10GB), users will not have to wait long times till the process finishes, so the process will not require much patience to be calmed down with an explicit progress bar.

Thanks a lot for the great effort, team!!!