Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Use Moshi to parse shares #3366

Merged
merged 5 commits into from
Sep 24, 2021
Merged

Conversation

fesave
Copy link
Contributor

@fesave fesave commented Sep 1, 2021

Related Issues

App: #3097

Library PR (if needed): owncloud/android-library#430


QA

Test report

@fesave fesave self-assigned this Sep 1, 2021
@fesave fesave linked an issue Sep 1, 2021 that may be closed by this pull request
14 tasks
@fesave fesave marked this pull request as ready for review September 1, 2021 09:45
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec
Copy link
Collaborator

jesmrec commented Sep 23, 2021

Tested with Appium tests (report in top message)

Approved on my side.

@fesave fesave force-pushed the feature/parse_shares branch from 3f75460 to d9c0602 Compare September 23, 2021 12:19
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@abelgardep abelgardep merged commit 3bff182 into master Sep 24, 2021
@abelgardep abelgardep deleted the feature/parse_shares branch September 24, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Use Moshi to parse shares
4 participants