Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unique gripper model per parent vehicle model #143

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

iche033
Copy link
Collaborator

@iche033 iche033 commented Jun 13, 2022

Signed-off-by: Ian Chen [email protected]

When spawning a UAV (or am on USV) with gripper, we run ERB to generate a new model.sdf file with a unique topic prefix name. The problem is that this file gets overwritten when there are multiple vehicles with grippers. The workaround here is to generate a whole new gripper model with the model.df in the mbzirc resource path. These generated gripper models will live in <colcon_ws>/install/share/mbzirc_ign/models/tmp directory. You'll need to source your setup file again to get this resource path.

Copy link
Collaborator

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@iche033 iche033 merged commit 08b70ef into arjo/experimental/multidrone_drag Jun 14, 2022
@iche033 iche033 deleted the unique_gripper_model branch June 14, 2022 18:02
iche033 added a commit that referenced this pull request Jun 20, 2022
…lock (#108)

* Adds a simple demo with multiple robots lifting the same overweight block.

> Note: Not sure if we really should be keeping this stuff in `mbzir_ign` or we should have a `mbzirc_demos` package.

This demo demonstrates using multiple robots to lift the same overweight block.

Requires gazebosim/gz-physics#345

## To Test
Make sure you have the right branch of gz-physics set up. Launch the test world file:
```bash
ign gazebo /your/path/to/mbzirc_ws/src/mbzirc/mbzirc_ign/worlds/test/multi_drone_lift.sdf
```
In another terminal run:
```bash
ros2 launch mbzirc_ign multi_uav_lift_demo.launch.py
```
You should see the drones spawn. After that run the simulators and let the robots fall onto the block. When the robots are resting on the block run:
```bash
ros2 run mbzirc_ign multi_uav_demo.py
```

Signed-off-by: Arjo Chakravarty <[email protected]>

* Address PR Feedback

Signed-off-by: Arjo Chakravarty <[email protected]>

* fix spawn multi uav

Signed-off-by: Ian Chen <[email protected]>

* fix params

Signed-off-by: Arjo Chakravarty <[email protected]>

* Add the test worlds

Signed-off-by: Arjo Chakravarty <[email protected]>

* more test stuff

Signed-off-by: Arjo Chakravarty <[email protected]>

* Added new large models for dragging into testing world, launch scripts for dragging

Signed-off-by: Aaron Chong <[email protected]>

* Cleaning up additional flat scenario on the roof

Signed-off-by: Aaron Chong <[email protected]>

* fix style (#141)

Signed-off-by: Ian Chen <[email protected]>

* Create unique gripper model per parent vehicle model (#143)

* create unique gripper model files per uav

Signed-off-by: Ian Chen <[email protected]>

* style

Signed-off-by: Ian Chen <[email protected]>

* Checking if gipper model name is a substring instead of direct compare (#145)

Signed-off-by: Aaron Chong <[email protected]>

Co-authored-by: Aaron Chong <[email protected]>

* fix style

Signed-off-by: Ian Chen <[email protected]>

* fix spawning uav without gripper

Signed-off-by: Ian Chen <[email protected]>

* fixing tests

Signed-off-by: Ian Chen <[email protected]>

* Updating doc in example lift and drag demos, adding detach flag in demo script

Signed-off-by: Aaron Chong <[email protected]>

* Clean up ununsed demo launch file

Signed-off-by: Aaron Chong <[email protected]>

Co-authored-by: Ian Chen <[email protected]>
Co-authored-by: Aaron Chong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants