fix: add cosmwasm_1_3 feature, use capabilities from wasm keeper #8764
Conversation
WalkthroughThe changes in the pull request primarily involve updates to the Changes
Suggested labels
Suggested reviewers
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
app/keepers/keepers.go (1)
577-578: LGTM: Addition of Osmosis-specific Wasm capabilities.The changes to add Osmosis-specific capabilities to the WasmKeeper are appropriate and align with the PR objectives. This allows for custom functionality within the Wasm module for Osmosis.
A minor suggestion for improvement:
Consider extracting the "osmosis" capability string to a constant for better maintainability. For example:
const OsmosisWasmCapability = "osmosis" // Then use it like this: wasmCapabilities = append(wasmCapabilities, OsmosisWasmCapability)This makes it easier to update or reference the capability name in the future if needed.
Also applies to: 599-601
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- app/keepers/keepers.go (2 hunks)
🧰 Additional context used
🔇 Additional comments (5)
CHANGELOG.md (5)
Line range hint
49-73: Significant unreleased changes detectedThe "Unreleased" section contains important changes, including state breaking modifications and new features. Notable changes include:
- State breaking changes like adding the cosmwasm_1_3 feature and updating the cosmwasm vm.
- Configuration changes such as enabling 1559 mempool by default.
- State compatible changes like adding additional queries in x/gauges.
These changes may have a significant impact on the system. It's crucial for developers and node operators to review and understand these modifications before the next release.
Line range hint
75-79: State machine breaking change in v26.0.1This minor release includes a single state machine breaking change:
- The
iterate delegationsfunction now continues instead of erroring when encountering an issue.This change could affect the behavior of delegation-related operations. Developers and node operators should be aware of this modification and test their systems accordingly to ensure compatibility.
Line range hint
81-116: Major changes in v26.0.0 releaseThis release includes numerous significant changes:
State breaking changes:
- SDK v50 and Comet v0.38 upgrade
- Changes to various modules including lockup, superfluid, and concentrated liquidity
- Updates to cosmwasm-related components
New features and improvements:
- Additional events in multiple modules
- Changes to pool creation fees and whitelist
- Updates to CLI commands and queries
Bug fixes:
- Fixes for protorev, smart account signing, and other issues
SDK upgrades:
- Upgrade to v0.50.6-v26-osmo-1 with various improvements
This release represents a substantial update to the system. Developers and node operators should carefully review all changes and test thoroughly before upgrading.
Line range hint
118-126: Performance improvements and bug fixes in v25.2.1This minor release focuses on enhancing system performance and fixing bugs:
- Reduced CPU time for epoch computations, which should improve overall system efficiency.
- De-duplicated fetching of intermediate accounts in the epoch module.
- Improved TWAP pruning logic for better performance.
- Added logging to track incentive accumulator truncation, enhancing observability.
These changes, while minor, should contribute to better system performance and easier debugging. Node operators should consider upgrading to benefit from these improvements.
Line range hint
128-1037: Comprehensive changelog structure and contentThe CHANGELOG.md file provides a detailed history of changes across multiple versions of the system. Key observations:
- Consistent structure: Each version is clearly demarcated with features, bug fixes, and improvements.
- Detailed descriptions: Changes are explained with sufficient detail, often including PR numbers for reference.
- Breaking changes: State-breaking changes are clearly highlighted in each relevant version.
- Version history: The changelog goes back to v1.0.0, providing a complete history of the system's evolution.
This comprehensive changelog is an excellent resource for developers, node operators, and users to understand the system's development over time. It aids in planning upgrades and understanding the introduction of new features or breaking changes.
Suggestion: Consider adding a table of contents at the beginning of the file to make navigation easier, especially as the changelog grows with future releases.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)
Line range hint
55-69: Significant new features and enhancementsThis release introduces several important features:
- SuperCharged Liquidity and CosmWasm Pool modules for enhanced capital efficiency and custom liquidity pools
- ProtoRev changes for improved backrunning and payment schedules
- TokenFactory before-send hooks for more flexible token transfers
- New governance features including expedited proposals
- Additional CLI commands and query improvements
These features provide new capabilities and optimizations that can benefit users and developers. However, they may also require updates to existing integrations and workflows.
Would you like me to provide more detailed explanations or examples for any of these new features?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- CHANGELOG.md (1 hunks)
🧰 Additional context used
🔇 Additional comments (5)
CHANGELOG.md (5)
Line range hint
1-49: Major release v19.0.0 introduces significant changes and new featuresThis release includes several important updates:
- Introduction of new modules: SuperCharged Liquidity and CosmWasm Pool Module
- Updates to existing APIs and dependencies
- ProtoRev changes affecting payment schedules and trade triggers
- TokenFactory improvements with before-send hooks
- Various state-breaking changes and bug fixes
These changes may require updates to integrations and could affect existing workflows. Users and developers should carefully review the changelog and test their applications against this new version.
Line range hint
71-86: Multiple API breaks and changesThis release includes several API changes that may affect existing integrations:
- New queries and CLI commands added for various modules
- Changes to existing query responses and parameters
- Deprecation of some x/gamm queries
- Renaming of "swap fee" to "spread factor"
Developers should carefully review these changes and update their applications accordingly. Special attention should be given to deprecated queries and renamed parameters to ensure compatibility with the new version.
#!/bin/bash # Check for any remaining references to deprecated gamm queries grep -R "EstimateSwapExactAmountIn" ./x/gamm grep -R "EstimateSwapExactAmountOut" ./x/gamm
Line range hint
88-101: Critical state-breaking changesThis release includes several state-breaking changes that will affect the network:
- Updates to ICA authorized messages
- TWAP record upgrade handler modifications
- Changes to synthetic lock handling
- New gas consumption mechanics for denom creation
- Modifications to gauge-related gas costs
- Changes to epoch handling and pool manager queries
These changes will require careful coordination during the upgrade process to ensure network consistency. Node operators and developers should pay close attention to these changes and follow the upgrade instructions carefully.
#!/bin/bash # Check for the presence of upgrade handlers grep -R "UpgradeHandler" ./app
Line range hint
103-107: Important dependency updatesThis release includes updates to key dependencies:
- wasmd upgraded to v0.31.0
- Cosmos SDK updated to v0.45.0x-osmo-v9.2
These updates may introduce new features and bug fixes from the upstream projects. Developers should review the changelogs of these dependencies to understand any potential impacts on their applications.
#!/bin/bash # Verify the versions of wasmd and cosmos-sdk in go.mod grep "github.com/CosmWasm/wasmd" go.mod grep "github.com/cosmos/cosmos-sdk" go.mod
Line range hint
51-53: Critical security update: wasmvm upgraded to 1.2.3This security upgrade addresses the vulnerability described in CWA-2023-002. It's crucial that all users upgrade to this version to ensure the security of their systems.
Closes: #XXX
What is the purpose of the change
Uses cpappabilities from wasm keeper instead of hard coded versions
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)