Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cosmwasm_1_3 feature #8763

Closed
wants to merge 1 commit into from
Closed

Conversation

keyleu
Copy link

@keyleu keyleu commented Oct 9, 2024

Closes: #8758

What is the purpose of the change

Currently osmosis doesn't have the cosmwasm_1_3 feature enabled (not sure if it was forgotten). This feature is required for cosmwasm_1_4, cosmwasm_2_0 and cosmwasm_2_1 (and more to come) so any contract which is built enabling any of these flags can't be uploaded to the chain at the moment.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Oct 9, 2024
Copy link
Contributor

coderabbitai bot commented Oct 9, 2024

Walkthrough

The changes in this pull request primarily enhance the keepers package in app/keepers/keepers.go. A new feature, "cosmwasm_1_3", is added to the supportedFeatures slice, improving the CosmWasm integration. Modifications include updates to the initialization of keeper instances, specifically the AuthenticatorManager and SmartAccountKeeper, as well as adjustments to the WasmKeeper and IBC transfer stack setup. The InitSpecialKeepers method is also updated to ensure proper configuration of additional keepers.

Changes

File Change Summary
app/keepers/keepers.go - Added "cosmwasm_1_3" to supportedFeatures in InitNormalKeepers.
- Updated initialization of AuthenticatorManager, SmartAccountKeeper, and WasmKeeper.
- Modified WireICS20PreWasmKeeper for new middleware.
- Updated InitSpecialKeepers to initialize CrisisKeeper, UpgradeKeeper, and ParamsKeeper.

Assessment against linked issues

Objective Addressed Explanation
Enable CosmWasm capabilities for v2.x (#8758)

Possibly related PRs

  • chore: update cosmwasm vm #8734: This PR updates the CosmWasm virtual machine (VM), which is directly related to the changes in the main PR that enhance the CosmWasm integration by adding support for version 1.3.

Suggested labels

V:state/compatible/backport, A:no-changelog

Suggested reviewers

  • nicolaslara
  • czarcas7ic

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 0711797 and cec8202.

📒 Files selected for processing (1)
  • app/keepers/keepers.go (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
app/keepers/keepers.go (1)

584-587: LGTM!

The addition of "cosmwasm_1_3" to the supportedFeatures slice correctly enables the CosmWasm 1.3 feature, aligning with the PR objectives to support newer CosmWasm versions.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mattverse
Copy link
Member

Replacing this PR with #8764

@mattverse mattverse closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring Changes to the app folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing CosmWasm capabilities for v2.x
2 participants