update OSMOSIS_E2E_UPGRADE_VERSION on upgrade handler #4029 #4173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
approved these changes
Jan 31, 2023
p0mvn
added
V:state/compatible/backport
|
Nice work! |
MasterPi-2124
added a commit
to notional-labs/osmosis
that referenced
this pull request
Jan 31, 2023
* update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json (osmosis-labs#4173) * e2e: Write node Docker container logs to a file (osmosis-labs#4118) * Write node Docker container logs to a file * add documentation * add documentation --------- Co-authored-by: ducnt131 <[email protected]>
p0mvn
pushed a commit
that referenced
this pull request
Feb 1, 2023
* update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json * test osmosis_e2e docker * test osmosis_e2e docker * e2e: Write node Docker container logs to a file (#4118) * Write node Docker container logs to a file * add documentation * add documentation * update (#6) * update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json (#4173) * e2e: Write node Docker container logs to a file (#4118) * Write node Docker container logs to a file * add documentation * add documentation --------- Co-authored-by: ducnt131 <[email protected]> * test osmosis_e2e docker * test osmosis_e2e docker * #4070 * Update push-dev-docker-images.yml --------- Co-authored-by: ducnt131 <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
* update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json * test osmosis_e2e docker * test osmosis_e2e docker * e2e: Write node Docker container logs to a file (#4118) * Write node Docker container logs to a file * add documentation * add documentation * update (#6) * update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json (#4173) * e2e: Write node Docker container logs to a file (#4118) * Write node Docker container logs to a file * add documentation * add documentation --------- Co-authored-by: ducnt131 <[email protected]> * test osmosis_e2e docker * test osmosis_e2e docker * #4070 * Update push-dev-docker-images.yml --------- Co-authored-by: ducnt131 <[email protected]> (cherry picked from commit 0dbb56a)
p0mvn
pushed a commit
that referenced
this pull request
Feb 1, 2023
* update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json * test osmosis_e2e docker * test osmosis_e2e docker * e2e: Write node Docker container logs to a file (#4118) * Write node Docker container logs to a file * add documentation * add documentation * update (#6) * update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json (#4173) * e2e: Write node Docker container logs to a file (#4118) * Write node Docker container logs to a file * add documentation * add documentation --------- Co-authored-by: ducnt131 <[email protected]> * test osmosis_e2e docker * test osmosis_e2e docker * #4070 * Update push-dev-docker-images.yml --------- Co-authored-by: ducnt131 <[email protected]> (cherry picked from commit 0dbb56a) Co-authored-by: Master Pi <[email protected]>
p0mvn
pushed a commit
that referenced
this pull request
Feb 1, 2023
…4173) (#4176) * update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json (#4173) (cherry picked from commit 386c9f0) # Conflicts: # scripts/empty_upgrade_handler_gen.sh * merge conflict fix --------- Co-authored-by: Master Pi <[email protected]> Co-authored-by: Ruslan Akhtariev <[email protected]>
p0mvn
pushed a commit
that referenced
this pull request
Feb 5, 2023
* update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json * test osmosis_e2e docker * test osmosis_e2e docker * e2e: Write node Docker container logs to a file (#4118) * Write node Docker container logs to a file * add documentation * add documentation * update (#6) * update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json (#4173) * e2e: Write node Docker container logs to a file (#4118) * Write node Docker container logs to a file * add documentation * add documentation --------- Co-authored-by: ducnt131 <[email protected]> * test osmosis_e2e docker * test osmosis_e2e docker * #4070 * Update push-dev-docker-images.yml * update to go1.19 * only update tests/localosmosis * missing --------- Co-authored-by: Master Pi <[email protected]> Co-authored-by: ducnt131 <[email protected]> Co-authored-by: Hieu Vu <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Feb 5, 2023
* update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json * test osmosis_e2e docker * test osmosis_e2e docker * e2e: Write node Docker container logs to a file (#4118) * Write node Docker container logs to a file * add documentation * add documentation * update (#6) * update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json (#4173) * e2e: Write node Docker container logs to a file (#4118) * Write node Docker container logs to a file * add documentation * add documentation --------- Co-authored-by: ducnt131 <[email protected]> * test osmosis_e2e docker * test osmosis_e2e docker * #4070 * Update push-dev-docker-images.yml * update to go1.19 * only update tests/localosmosis * missing --------- Co-authored-by: Master Pi <[email protected]> Co-authored-by: ducnt131 <[email protected]> Co-authored-by: Hieu Vu <[email protected]> (cherry picked from commit d92be8b)
p0mvn
pushed a commit
that referenced
this pull request
Feb 5, 2023
* update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json * test osmosis_e2e docker * test osmosis_e2e docker * e2e: Write node Docker container logs to a file (#4118) * Write node Docker container logs to a file * add documentation * add documentation * update (#6) * update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json (#4173) * e2e: Write node Docker container logs to a file (#4118) * Write node Docker container logs to a file * add documentation * add documentation --------- Co-authored-by: ducnt131 <[email protected]> * test osmosis_e2e docker * test osmosis_e2e docker * #4070 * Update push-dev-docker-images.yml * update to go1.19 * only update tests/localosmosis * missing --------- Co-authored-by: Master Pi <[email protected]> Co-authored-by: ducnt131 <[email protected]> Co-authored-by: Hieu Vu <[email protected]> (cherry picked from commit d92be8b) Co-authored-by: Dong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4029
What is the purpose of the change
Code-gen upgrade handler PR(#4052 example) will automatically bump OSMOSIS_E2E_UPGRADE_VERSION in launch.json.
Tested PR can be seen here: https://github.com/notional-labs/osmosis/pull/3/files
Brief Changelog
(for example:)
Testing and Verifying
This change is already covered by existing tests, such as notional-labs#3