Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update OSMOSIS_E2E_UPGRADE_VERSION on upgrade handler #4029 #4173

Merged
merged 2 commits into from
Jan 31, 2023
Merged

update OSMOSIS_E2E_UPGRADE_VERSION on upgrade handler #4029 #4173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
055597e
Merge pull request #1 from osmosis-labs/main
MasterPi-2124 Jan 31, 2023
1389272
update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json
MasterPi-2124 Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/gen-upgrade-on-manual-input.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# When user trigger this workflow with custom version input, this action will do 3 things:
# 1) it will create a directory with an empty upgrade handler in app/upgrades folder
# 2) will increase an E2E_UPGRADE_VERSION variable in Makefile
# 3) create a pull request with these changes to main
# 1) create a directory with an empty upgrade handler in app/upgrades folder
# 2) increase E2E_UPGRADE_VERSION variable in Makefile
# 3) update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json
# 4) create a pull request with these changes to main

# Please note that if the given version (or release major version) is smaller than the latest
# existing upgrade handler version in `app/upgrades/`, this will be a no-op.
Expand Down Expand Up @@ -58,6 +59,7 @@ jobs:
Update report
- Created a new empty upgrade handler
- Increased E2E_UPGRADE_VERSION in Makefile by 1
- Increased OSMOSIS_E2E_UPGRADE_VERSION in .vscode/launch.json by 1
labels: |
T:auto
C:e2e
Expand Down
8 changes: 6 additions & 2 deletions scripts/empty_upgrade_handler_gen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@

# 1) this script creates an empty directory in app/upgrades called "vX" where X is a previous version + 1 with an empty upgrade handler.
# 2) adds new version to app.go
# 3) increases E2E_UPGRADE_VERSION in makefile by 1
# 4) bumps up previous e2e-init version in tests/e2e/containers/config.go
# 3) update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json
# 4) increases E2E_UPGRADE_VERSION in makefile by 1
# 5) bumps up previous e2e-init version in tests/e2e/containers/config.go

# Also insures that all the imports make use of a current module version from go mod:
# (see: module=$(go mod edit -json | jq ".Module.Path") in this script)
Expand Down Expand Up @@ -119,3 +120,6 @@ else
echo "Using pre-defined osmosis-e2e-init-chain tag: $PREV_OSMOSIS_E2E_TAG"
sed -i '/previousVersionInitTag/s/".*"/'"\"$PREV_OSMOSIS_E2E_TAG\""'/' $e2e_file
fi

# update OSMOSIS_E2E_UPGRADE_VERSION in launch.json
sed -i "s/${bracks}OSMOSIS_E2E_UPGRADE_VERSION${bracks}: ${bracks}v$latest_version${bracks}/${bracks}OSMOSIS_E2E_UPGRADE_VERSION${bracks}: ${bracks}$version_create${bracks}/" ./.vscode/launch.json
p0mvn marked this conversation as resolved.
Show resolved Hide resolved