Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dong/updateto1.19 #4216

Merged
merged 15 commits into from
Feb 5, 2023
Merged

Dong/updateto1.19 #4216

merged 15 commits into from
Feb 5, 2023

Conversation

DongLieu
Copy link
Contributor

@DongLieu DongLieu commented Feb 3, 2023

Closes: #4212

What is the purpose of the change

Update to go 1.19

Add a description of the overall background and high level changes that this PR introduces

(E.g.: This pull request improves documation of area A by adding ....

Brief Changelog

(for example:)

  • The metadata is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • Daemons retrieve the RPC data from the blob cache

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added unit test that validates ...
  • Added integration tests for end-to-end deployment with ...
  • Extended integration test for ...
  • Manually verified the change by ...

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@pysel pysel added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Feb 3, 2023
@pysel pysel marked this pull request as draft February 3, 2023 06:13
@github-actions github-actions bot removed the T:CI label Feb 3, 2023
Copy link
Member

@pysel pysel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@pysel pysel marked this pull request as ready for review February 3, 2023 13:43
@pysel pysel requested a review from czarcas7ic February 3, 2023 13:43
@ValarDragon ValarDragon added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v14.x backport patches to v14.x branch and removed V:state/compatible/no_backport State machine compatible PR, depends on prior breaks labels Feb 4, 2023
@p0mvn p0mvn merged commit d92be8b into osmosis-labs:main Feb 5, 2023
mergify bot pushed a commit that referenced this pull request Feb 5, 2023
* update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json

* test osmosis_e2e docker

* test osmosis_e2e docker

* e2e: Write node Docker container logs to a file (#4118)

* Write node Docker container logs to a file

* add documentation

* add documentation

* update (#6)

* update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json (#4173)

* e2e: Write node Docker container logs to a file (#4118)

* Write node Docker container logs to a file

* add documentation

* add documentation

---------

Co-authored-by: ducnt131 <[email protected]>

* test osmosis_e2e docker

* test osmosis_e2e docker

* #4070

* Update push-dev-docker-images.yml

* update to go1.19

* only update tests/localosmosis

* missing

---------

Co-authored-by: Master Pi <[email protected]>
Co-authored-by: ducnt131 <[email protected]>
Co-authored-by: Hieu Vu <[email protected]>
(cherry picked from commit d92be8b)
p0mvn pushed a commit that referenced this pull request Feb 5, 2023
* update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json

* test osmosis_e2e docker

* test osmosis_e2e docker

* e2e: Write node Docker container logs to a file (#4118)

* Write node Docker container logs to a file

* add documentation

* add documentation

* update (#6)

* update OSMOSIS_E2E_UPGRADE_VERSION variable in .vscode/launch.json (#4173)

* e2e: Write node Docker container logs to a file (#4118)

* Write node Docker container logs to a file

* add documentation

* add documentation

---------

Co-authored-by: ducnt131 <[email protected]>

* test osmosis_e2e docker

* test osmosis_e2e docker

* #4070

* Update push-dev-docker-images.yml

* update to go1.19

* only update tests/localosmosis

* missing

---------

Co-authored-by: Master Pi <[email protected]>
Co-authored-by: ducnt131 <[email protected]>
Co-authored-by: Hieu Vu <[email protected]>
(cherry picked from commit d92be8b)

Co-authored-by: Dong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v14.x backport patches to v14.x branch T:build V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localosmosis: bump go version to v1.19
7 participants