Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(CL Swaps): reduce complexity around swap logic #4424

Closed
6 tasks done
Tracked by #3014
p0mvn opened this issue Feb 27, 2023 · 0 comments
Closed
6 tasks done
Tracked by #3014

refactor(CL Swaps): reduce complexity around swap logic #4424

p0mvn opened this issue Feb 27, 2023 · 0 comments
Assignees
@p0mvn
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:tracking issue ⛰
Milestone
CL 9

Comments

@p0mvn
Copy link
Member

p0mvn commented Feb 27, 2023 •
edited
Loading

Background

Currently, the swap logic is needlessly complex and poorly tested. As more reviews are conducted, more and more bugs keep re-ocurring. For example #4423

Suggested Design

We need to refactor and simplify the swaps logic to make it simpler and more testable.

Issues

Tasks
Preview Give feedback
  1. fix(CL Swaps): bug in swap in given out in related to zero for one logic #4423
    C:x/concentrated-liquidity F: concentrated-liquidity T:bug 🐛
    p0mvn
  2. refactor(CL Swaps): swap API bank sends: SwapOutAmtGivenIn #4425
    C:x/concentrated-liquidity F: concentrated-liquidity
    czarcas7ic
  3. refactor(CL Swaps): remove redundant swap API: SwapInAmtGivenOut #4426
    C:x/concentrated-liquidity F: concentrated-liquidity
    czarcas7ic
  4. refactor: compute swap step #4427
    F: concentrated-liquidity
    p0mvn
  5. [CL]: SwapInverseTest errTolerance #4475
    C:x/concentrated-liquidity F: concentrated-liquidity
    p0mvn
  6. fix: truncation around swap steps and fees #4645
    F: concentrated-liquidity T:bug 🐛
    p0mvn

Acceptance Criteria

  • suggestions implemeted
  • tests added
@p0mvn p0mvn added T:tracking issue ⛰ F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Feb 27, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Feb 27, 2023
@p0mvn p0mvn added T:ice-box and removed T:ice-box labels Feb 27, 2023
@p0mvn p0mvn added this to the CL 9 milestone Feb 28, 2023
@p0mvn p0mvn mentioned this issue Mar 4, 2023
Merged
@p0mvn p0mvn self-assigned this Mar 26, 2023
@p0mvn p0mvn moved this from Needs Triage 🔍 to In Progress🏃 in Osmosis Chain Development Mar 26, 2023
@p0mvn p0mvn mentioned this issue Mar 27, 2023
Closed
@p0mvn p0mvn closed this as completed Mar 28, 2023
@github-project-automation github-project-automation bot moved this from In Progress🏃 to Done ✅ in Osmosis Chain Development Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:tracking issue ⛰
Projects
Osmosis Chain Development
Archived in project
Milestone
CL 9
Development

No branches or pull requests
1 participant
@p0mvn