[CL]: SwapInverseTest errTolerance

[czarcas7ic]

Background

Previously for the SwapIn/OutAmtGivenOut/In inverse tests, we checked if the user and pool balances after the swap were EXACTLY the same:

osmosis/x/concentrated-liquidity/swaps_test.go

Lines 2079 to 2083 in 03f2a98

	// Assure that user balance now as it was before both swaps.
	userBalanceAfterSwap := s.App.BankKeeper.GetAllBalances(s.Ctx, s.TestAccs[0])
	poolBalanceAfterSwap := s.App.BankKeeper.GetAllBalances(s.Ctx, poolBefore.GetAddress())
	s.Require().Equal(userBalanceBeforeSwap, userBalanceAfterSwap)
	s.Require().Equal(poolBalanceBeforeSwap, poolBalanceAfterSwap)

This passed because we weren't actually doing bank sends on the expected method. In a recent PR, bank sends were added, and now this test only passes when adding a error tolerance.

osmosis/x/concentrated-liquidity/swaps_test.go

Lines 2079 to 2087 in bb91cf6

	// Assure that user balance now as it was before both swaps.
	userBalanceAfterSwap := s.App.BankKeeper.GetAllBalances(s.Ctx, s.TestAccs[0])
	poolBalanceAfterSwap := s.App.BankKeeper.GetAllBalances(s.Ctx, poolBefore.GetAddress())
	for _, coin := range userBalanceBeforeSwap {
	s.Require().Equal(0, errTolerance.Compare(userBalanceBeforeSwap.AmountOf(coin.Denom), userBalanceAfterSwap.AmountOf(coin.Denom)))
	}
	for _, coin := range poolBalanceBeforeSwap {
	s.Require().Equal(0, errTolerance.Compare(poolBalanceBeforeSwap.AmountOf(coin.Denom), poolBalanceAfterSwap.AmountOf(coin.Denom)))
	}

Suggested Design

• Prior to addressing this, investigate the potential use of BigDec for swaps
  • If we use BigDecs, the diff here should be minimal if not non-existent and this can we swapped back
  • If we dont use BigDec, check if the tolerance used here is acceptable