Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(CL Swaps): swap API bank sends: SwapOutAmtGivenIn #4425

Closed
Tracked by #4424
p0mvn opened this issue Feb 27, 2023 · 0 comments · Fixed by #4474
Closed
Tracked by #4424

refactor(CL Swaps): swap API bank sends: SwapOutAmtGivenIn #4425

p0mvn opened this issue Feb 27, 2023 · 0 comments · Fixed by #4474
Assignees
@czarcas7ic
Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Milestone
CL 9

Comments

@p0mvn
Copy link
Member

p0mvn commented Feb 27, 2023 •
edited by czarcas7ic
Loading

Background

Currently, we have 2 public swap APIs :

We should refactor the wiring of this so that

  • SwapOutAmtGivenIn is an internal method
  • all mutations (to include bank sends) happen in the internal method

Acceptance Criteria

  • suggestion implemented
  • tests updated
  • all continue to pass
@p0mvn p0mvn added C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Feb 27, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Feb 27, 2023
@p0mvn p0mvn mentioned this issue Feb 27, 2023
Closed
@p0mvn p0mvn mentioned this issue Feb 27, 2023
Closed
@p0mvn p0mvn removed the T:ice-box label Feb 28, 2023
@p0mvn p0mvn added this to the CL 9 milestone Feb 28, 2023
@czarcas7ic czarcas7ic self-assigned this Mar 1, 2023
@czarcas7ic czarcas7ic mentioned this issue Mar 1, 2023
Merged
@czarcas7ic czarcas7ic changed the title refactor(CL Swaps): remove redundant swap API: SwapOutAmtGivenIn refactor(CL Swaps): swap API bank sends: SwapOutAmtGivenIn Mar 1, 2023
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czarcas7ic czarcas7ic

Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
CL 9
Development

Successfully merging a pull request may close this issue.

CL: make swapOutAmtGivenIn mutate user/pool balances osmosis-labs/osmosis
2 participants
@p0mvn @czarcas7ic