Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: compute swap step #4427

Closed
Tracked by #4424
p0mvn opened this issue Feb 27, 2023 · 0 comments · Fixed by #4500
Closed
Tracked by #4424

refactor: compute swap step #4427

p0mvn opened this issue Feb 27, 2023 · 0 comments · Fixed by #4500
Assignees
@p0mvn
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@p0mvn
Copy link
Member

p0mvn commented Feb 27, 2023

Background

Compute swap step logic is currently convoluted and poorly tested. We should refactor it to make it simpler to follow.

Suggested Design

Separate ComputeSwapStep interface into ComputeSwapStepOutGivenIn and ComputeSwapStepInGivenOut.

Implement all for each swap strategy ("zero for one" and "one for zero")

Acceptance Criteria

  • swap strategy interface refactored
  • implementation for each interface
  • update tests
@p0mvn p0mvn added F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:ice-box labels Feb 27, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Feb 27, 2023
@p0mvn p0mvn mentioned this issue Feb 27, 2023
Closed
@p0mvn p0mvn self-assigned this Feb 27, 2023
@p0mvn p0mvn mentioned this issue Feb 27, 2023
Closed
@p0mvn p0mvn removed the T:ice-box label Feb 28, 2023
@p0mvn p0mvn mentioned this issue Mar 2, 2023
Merged
@p0mvn p0mvn moved this from Needs Triage 🔍 to In Progress🏃 in Osmosis Chain Development Mar 2, 2023
@p0mvn p0mvn mentioned this issue Mar 4, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress🏃 to Done ✅ in Osmosis Chain Development Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
1 participant
@p0mvn