-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hash method for RayVector
#4354
Conversation
With this notion we already have a good distinction what could be equal. The disadvantage is that calculating the sign could be too demanding for more complex coefficient fields? If so, we could utilize the efficient |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4354 +/- ##
==========================================
+ Coverage 84.31% 84.34% +0.03%
==========================================
Files 649 651 +2
Lines 86345 86525 +180
==========================================
+ Hits 72799 72980 +181
+ Misses 13546 13545 -1
|
Can you add a small test for this, maybe like this: @test length(Set(ray_vector.([[1,2,3],[2,4,6],[-1,-2,-3]]))) == 2 |
I think the sign is fine. |
Backports for release 1.2.2: fix galois_group problem. #4396 Fix zero-dimensional cone in cones in PolyhedralGeometry #4336 Fix up generic characteristic method for localized rings. #4346 test/PolyhedralGeometry: remove some prefer blocks #4351 Add comment about bibtool version, minor fix in testsuite #4356 Add hash method for RayVector #4354 Fix indent in AlgebraicCycles.md #4368 Fix toric typo #4367
No description provided.