Add hash method for RayVector (#4354)

* added hash method for RayVector; fixed wrong test

* add isequal and corresponding test for RayVector

src/PolyhedralGeometry/iterators.jl

@@ -106,6 +106,10 @@ Base.:(==)(::PointVector, ::RayVector) =
 Base.:(==)(::RayVector, ::PointVector) =
   throw(ArgumentError("Cannot compare PointVector to RayVector"))
 
+Base.isequal(x::RayVector, y::RayVector) = x == y
+
+Base.hash(x::RayVector, h::UInt) = hash(collect(sign.(x)), hash(coefficient_field(x), h))
+
 ################################################################################
 ######## Halfspaces and Hyperplanes
 ################################################################################

test/PolyhedralGeometry/cone.jl

@@ -28,7 +28,7 @@
     if T == QQFieldElem
       @test hilbert_basis(Cone1) isa SubObjectIterator{PointVector{ZZRingElem}}
       @test length(hilbert_basis(Cone1)) == 2
-      @test issetequal(hilbert_basis(Cone1), ray_vector.(Ref(ZZ), [[1, 0], [0, 1]]))
+      @test issetequal(hilbert_basis(Cone1), point_vector.(Ref(ZZ), [[1, 0], [0, 1]]))
       @test generator_matrix(hilbert_basis(Cone1)) == _oscar_matrix_from_property(ZZ, hilbert_basis(Cone1))
     end
     @test n_rays(Cone1) == 2

test/PolyhedralGeometry/types.jl

@@ -109,6 +109,9 @@
           end
         end
       end
+      if T == RayVector
+        @test length(Set(ray_vector.(Ref(f), [[1,2,3],[2,4,6],[-1,-2,-3]]))) == 2
+      end
     end
   end