Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix galois_group problem. #4396

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix galois_group problem. #4396

merged 1 commit into from
Dec 11, 2024

Conversation

fieker
Copy link
Contributor

@fieker fieker commented Dec 11, 2024

The previous last fix changed the order in which the factors were processed - this broke unfortunately that part in the end that adds the multiplicity back in.

The current version is not perfect (unneccessary computations are done) but fixes the problem

The previous last fix changed the order in which the factors
were processed - this broke unfortunately that part in the end
that adds the multiplicity back in.

The current version is not perfect (unneccessary computations are done)
but fixes the problem
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (d6230ef) to head (4e20b55).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4396      +/-   ##
==========================================
+ Coverage   84.38%   84.40%   +0.01%     
==========================================
  Files         656      656              
  Lines       87198    87214      +16     
==========================================
+ Hits        73583    73609      +26     
+ Misses      13615    13605      -10     
Files with missing lines Coverage Δ
src/NumberTheory/GaloisGrp/GaloisGrp.jl 79.50% <100.00%> (+0.88%) ⬆️

@micjoswig
Copy link
Member

micjoswig commented Dec 11, 2024

@fieker Thanks for addressing this quickly. Ideally, after the merge, we could produce a v1.2.2 with this patch.

@thofma thofma merged commit 50b081e into master Dec 11, 2024
30 of 31 checks passed
@thofma thofma deleted the FixGal branch December 11, 2024 18:48
@thofma
Copy link
Collaborator

thofma commented Dec 11, 2024

@benlorenz could you do initiate the steps for v1.2.2?

benlorenz pushed a commit that referenced this pull request Dec 11, 2024
The previous last fix changed the order in which the factors
were processed - this broke unfortunately that part in the end
that adds the multiplicity back in.

The current version is not perfect (unneccessary computations are done)
but fixes the problem

(cherry picked from commit 50b081e)
@benlorenz benlorenz mentioned this pull request Dec 11, 2024
benlorenz added a commit that referenced this pull request Dec 13, 2024
Backports for release 1.2.2:

fix galois_group problem. #4396
Fix zero-dimensional cone in cones in PolyhedralGeometry #4336
Fix up generic characteristic method for localized rings. #4346
test/PolyhedralGeometry: remove some prefer blocks #4351
Add comment about bibtool version, minor fix in testsuite #4356
Add hash method for RayVector #4354
Fix indent in AlgebraicCycles.md #4368
Fix toric typo #4367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants