Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init hydra consent and bump versions #228

Closed

Conversation

jonasbadstuebner
Copy link
Contributor

@jonasbadstuebner jonasbadstuebner commented Dec 12, 2022

I wanted to include Hydra consent in Kratos and this is working, "but" I also bumped the versions up to v1.1.0.
The Hydra-Consent page is not implemented if you don't specify HYDRA_ADMIN_URL as Environment variable. So it's optional and does not/should not break existing implementations.

I copy-pasted a lot from the Hydra-native implementation, so if you want some comments to be removed or whatever, just let me know, we can easily do that.

It uses the ory-native UserConsentCard for rendering the consent page and falls back to the default ory logo if no specific logo_uri is given on the client.

Related Issue or Design Document

Fixes #224
Closes #225

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonasbadstuebner jonasbadstuebner changed the title init hydra consent and bump versions feat: init hydra consent and bump versions Dec 12, 2022
@jonasbadstuebner jonasbadstuebner mentioned this pull request Dec 12, 2022
6 tasks
@Benehiko
Copy link
Contributor

Hey @DrBu7cher

Thank you for the contribution! I have cherry-picked this PR to a new branch and removed the consent routes here #229.

I did this since we require this repository on the latest SDK version, but do not currently have the time to review the consent routes right now - unfortunately 😞.

I hope you understand
Your contributions will still be in the new PR since it was a cherry-pick :)

@jonasbadstuebner
Copy link
Contributor Author

Hey, @Benehiko ,

I understand, this is totally up to you. I extended my fork to also cover including the email in the id_token, since I needed that for my Grafana to work.
I am actively using this consent page and it's working great, since it uses your native UserConsentCard and the same logic as your hydra-consent-example.

If any time in the future one would like to combine the two examples, maybe this PR can be looked at again. :)

Best regards and thank you!

@Benehiko
Copy link
Contributor

I have merged the other PR, so just rebase here - there shouldn't be a lot of conflicts since they were from the same commits.

I think you can keep this PR open and we will review it once we get the time ;)

jonasbadstuebner added a commit to jonasbadstuebner/ory-selfservice-ui-node that referenced this pull request Dec 22, 2022
With `TRUSTED_CLIENT_IDS` you can specify a comma seperated list of clients that don't need manual user consent.
Specify `KRATOS_ADMIN_URL` to get email and maybe phone for user if scope is granted.
With `HYDRA_ADMIN_URL` specified you get the consent capability.
Keto is not set up nicely (yet), but the outlines are there.
`MOCK_TLS_TERMINATION`(=y) is supported.

PR ory#228
@davidspek
Copy link

@DrBu7cher @Benehiko Could one of you reopen this PR? I think it got closed in the process of rebasing because it caused there to be no changes. However, the commit that was created after the PR was closed does contain changes.

davidspek pushed a commit to pluralsh/kratos-selfservice-ui-node that referenced this pull request Feb 16, 2023
With `TRUSTED_CLIENT_IDS` you can specify a comma seperated list of clients that don't need manual user consent.
Specify `KRATOS_ADMIN_URL` to get email and maybe phone for user if scope is granted.
With `HYDRA_ADMIN_URL` specified you get the consent capability.
Keto is not set up nicely (yet), but the outlines are there.
`MOCK_TLS_TERMINATION`(=y) is supported.

PR ory#228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement consent page for Hydra implementation
3 participants