Bump to @ory/client 1.0.1 #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vinckr 👀 |
|
Could we update this to bump to v1.1.0 right away? |
jonas-jonas
requested changes
Dec 12, 2022
| return { | ||
| apiBaseUrl: apiBaseUrl, | ||
| kratosBrowserUrl: apiBaseUrl, | ||
| sdk, | ||
| frontend: new FrontendApi(), |
There was a problem hiding this comment.
Suggested change
| frontend: new FrontendApi(), | |
| ...sdk |
That way you have frontend (and the other APIs) available, but they're setup with the correct configuration.
| import { Application, NextFunction, Request, Response } from "express" | ||
|
|
||
| export interface RouteOptions { | ||
| sdk: V0alpha2ApiInterface | ||
| frontend: FrontendApi |
There was a problem hiding this comment.
Suggested change
| frontend: FrontendApi | |
| frontend: FrontendApi | |
| identity: IdentityApi | |
| oauth2: OAuth2Api |
| await sdk | ||
| .createSelfServiceLogoutFlowUrlForBrowsers(req.header("cookie")) | ||
| await frontend | ||
| .createBrowserLogoutFlow(req.header("cookie")) |
There was a problem hiding this comment.
Instead of passing these parameters as named parameters, they're now passed in a single params object. Could you update the usage of these methods as well? It won't compile otherwise.
6 tasks
jonasbadstuebner
added a commit
to jonasbadstuebner/ory-selfservice-ui-node
that referenced
this pull request
Dec 12, 2022
|
@jonas-jonas Please have a look at #228 |
Benehiko
pushed a commit
that referenced
this pull request
Dec 14, 2022
Benehiko
added a commit
that referenced
this pull request
Dec 14, 2022
* linting: refactoring as in #225 * chore: cleanup * chore: bump ory/integrations * style: format * chore: cleanup * fix: login and registration hydra integration Co-authored-by: Jonas Badstübner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments