Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement consent page for Hydra implementation #224

Closed
3 of 6 tasks
lus opened this issue Nov 19, 2022 · 13 comments
Closed
3 of 6 tasks

Implement consent page for Hydra implementation #224

lus opened this issue Nov 19, 2022 · 13 comments
Labels
feat New feature or request.

Comments

@lus
Copy link

lus commented Nov 19, 2022

Preflight checklist

Describe your problem

I am currently using the latest (alpha) version of this project.
I am aware that there is a reason that it is in an alpha state, so this issue should not be a complaint, but rather a question
Will there be a solution implemented to be able to complete Hydra's consent flow directly with this UI?
I really like its design and want to use it while focusing on other parts of my infrastructure before implementing my own.
Thank you very much for the hard work you put into your really nice products, I am looking forward to integrating them more within my application!

Describe your ideal solution

It would be very nice if this feature would be implemented in this UI.

Workarounds or alternatives

A workaround that would come to my mind is using the example Hydra consumer application just for consents.

Version

v0.11.0-alpha.0.pre.0

Additional Context

No response

@lus lus added the feat New feature or request. label Nov 19, 2022
@aeneasr
Copy link
Member

aeneasr commented Nov 21, 2022

We will most likely add this integration here as well, but it's currently not on the priority list because our backlog is so immense and it requires testing etc...

But if you're interested in tackling this we definitely welcome any contributions!

@lus
Copy link
Author

lus commented Nov 21, 2022

Alright, I understand. Unfortunately I absolutely hate developing JS/TS so I would be the wrong person for this job, but I created a simple service that implements consents + Kratos trait propagation here if anyone has the same requirements as I do.
Apart from that, thank you very much for the work you put into all of your projects, it's fun to set them up and use them!

@jonasbadstuebner
Copy link
Contributor

I have a solution ready to be used over at my fork.

@jonasbadstuebner
Copy link
Contributor

It also bumps versions up.

@mattbarnicle
Copy link

mattbarnicle commented Feb 8, 2023

@DrBu7cher i checked out the https://github.com/DrBu7cher/ory-selfservice-ui-node/tree/add_hydra_consent_page repo and branch, but I don't see how to get it to run in Docker. i don't see a docker-compose.yml file anywhere in the code. can you help me figure out how to do that? i also can't figure out how to get it working outside of Docker either.

@davidspek
Copy link

@mattbarnicle If you would like to test that branch I pushed an image to davidspek/kratos-selfservice-ui-node:hydra-consent-1 that you can try. I'm currently running into an issue with it though so it very well might be broken. If I manage to solve the problem I'll update with a new image you can test.

@davidspek
Copy link

I've solved the issue with the consent page rendering and can confirm it is working now. You can test with image davidspek/kratos-selfservice-ui-node:hydra-consent-2. Since the original PR is closed and a small fix needed to be added I created a new PR to get this integrated. See #248.

@jonasbadstuebner
Copy link
Contributor

@mattbarnicle You build by executing docker build -t whatever . :)

@davidspek I don’t know how the consent view got lost, but I’m glad you found it :D

@mattbarnicle
Copy link

@davidspek thanks for the fix and the comment. i checked out your PR and got it to build. however I still can't get it to work in my environment. but I'm not running it the way you are. I'm trying to get it working inside a local Dockerized internal network, as that is they way we run things in our projects. i don't know if you can't help out with that but i'll explain below.

@DrBu7cher sorry, i didn't properly explain myself. as i said above to David, I'm not just trying to build the project in Docker, but to build it within a Dockerized setup where this, the Hydra, and Kratos containers are all running within the same network, launched via a docker-compose file. i explained what i did here: ory/kratos#2976 (reply in thread)

so i copied that same dir into the contrib/hydra dir in the #248 PR checkout and ran docker-compose up --build. the build works and i can load the welcome page in the browser, but when i click on either of the auth links (sign in or sign up), i get a 404 error. the sign up link opens this URL: http://127.0.0.1:3000/.ory/kratos/public/self-service/registration/browser?

i don't know if either of you can help with this but this is the issue I'm facing and i don't know what to do. any advice or information you could give would be fantastic. but if not that's ok. i'm currently working with Vincent from Ory on this in another branch too.

@lus
Copy link
Author

lus commented Feb 17, 2023

@mattbarnicle you need to set the KRATOS_PUBLIC_URL to the URL users from outside can reach the public API of you Kratos instance

@davidspek
Copy link

You probably also need to set the following in the kratos config yaml:

serve:
  public:
    base_url: http://some-host/.ory/kratos/public/

Also, don't forget to set the HYDRA_ADMIN_URL environment variable on the kratos-selfservice-ui-node container. I'm running this within Kubernetes which in this situation is exactly the same as what you are doing with docker-compose, so it definitely is possible. There are some other issues I found in the quickstart, so if you need any more help you can let me know. I can also share a helm chart I'm using for some initial testing of a new project that setups up Kratos, Hydra, Oathkeeper and this UI.

@mattbarnicle
Copy link

thanks for the feedback @lus and @davidspek. i already have those things set in my docker yml files. i just don't understand why they don't work with the values I've set them to.

@aeneasr
Copy link
Member

aeneasr commented Jun 27, 2023

This is done now!

@aeneasr aeneasr closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
5 participants