-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a segfault when not all writers contributed to a global variable #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just tested on Titan. I got the following error in the middle. Full log is in
|
What command line parameters for each side?
g
… On Jun 22, 2018, at 6:20 PM, Jong Choi ***@***.***> wrote:
Just tested on Titan. I got the following error in the middle:
[ANAL:4] #0 0x6d8faf in ???
[ANAL:4] at /usr/src/packages/BUILD/glibc-2.11.3/nptl/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
[ANAL:4] #1 0x9229fb in ???
[ANAL:4] at ../sysdeps/x86_64/multiarch/../memcpy.S:267
[ANAL:4] #2 0x59feb8 in ExtractSelectionFromPartialCM
[ANAL:4] at /lustre/atlas/world-shared/csc143/jyc/titan/sw/src/adios2-devel/source/adios2/toolkit/sst/cp/ffs_marshal.c:1076
[ANAL:4] #3 0x5a00e8 in FillReadRequests
[ANAL:4] at /lustre/atlas/world-shared/csc143/jyc/titan/sw/src/adios2-devel/source/adios2/toolkit/sst/cp/ffs_marshal.c:1110
[ANAL:4] #4 0x5a00e8 in SstFFSPerformGets
[ANAL:4] at /lustre/atlas/world-shared/csc143/jyc/titan/sw/src/adios2-devel/source/adios2/toolkit/sst/cp/ffs_marshal.c:1128
[ANAL:4] #5 0x52db43 in _ZN6adios24core6engine9SstReader7EndStepEv
[ANAL:4] at /lustre/atlas/world-shared/csc143/jyc/titan/sw/src/adios2-devel/source/adios2/engine/sst/SstReader.cpp:209
[ANAL:4] #6 0x43b719 in adios2_end_step
[ANAL:4] at /lustre/atlas/world-shared/csc143/jyc/titan/sw/src/adios2-devel/bindings/C/c/adios2_c_engine.cpp:253
[ANAL:4] #7 0x42c8a6 in adios2_end_step_f2c_
[ANAL:4] at /lustre/atlas/world-shared/csc143/jyc/titan/sw/src/adios2-devel/bindings/Fortran/f2c/adios2_f2c_engine.cpp:142
[ANAL:4] #8 0x40e747 in reader
[ANAL:4] at /lustre/atlas/proj-shared/csc143/jyc/titan/adios2-heat2d/analysis/heatAnalysis_adios2_stream.F90:116
[ANAL:4] #9 0x406b2c in main
[ANAL:4] at /lustre/atlas/proj-shared/csc143/jyc/titan/adios2-heat2d/analysis/heatAnalysis_adios2_stream.F90:2
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#686 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5fmfAVgYG5K8KgNp6Ud6byQLtclZT0ks5t_W3KgaJpZM4U0SGA>.
|
|
williamfgc
pushed a commit
to williamfgc/ADIOS2
that referenced
this pull request
Jun 26, 2018
Code extracted from: https://github.com/nlohmann/json.git at commit d2dd27dc3b8472dbaa7d66f83619b3ebcd9185fe (v3.1.2). Upstream Shortlog ----------------- Alexander “weej” Jones (1): 836f1c41 🎨 Namespace `uint8_t` from the C++ stdlib Berkus Decker (1): b14629b0 Fix typo Chocobo1 (2): 66ffac9e Fix MSVC warning C4819 0395f3fd fix typo DmitryKuk (1): 19437c15 massage -> message Eren Okka (1): ab0e8b2f Fix MSVC warning C4819 Greg Hurrell (1): 39130352 Fix "not constraint" grammar in docs HenryLee (18): ed62129f Override n + iterator operator in the iterator adc73d6d Fix the arithmetic mistakes in reverse iterator a3bf0131 Fix some more reverse iterator arithmetic test codes 3aef1a58 Change the definition of the operator override of reverse iterator to using the result of the base class directly e42db27d Fix the indentation from the latest commit 5b245dae Comment out the exception message check in operator[] of reverse iterator 0c2ed00e Add missing test cases for n + it arithmetic in iterators daea213b Use static cast in the implementation of the operators of reverse iterator c4ab8f82 Change iterator category to random access ce39330f Add converting constructors for iterator 790e7ca9 Add struct keyword in front of internal_iterator 881cd3f4 Remove the iter_impl<const basic_json> copy constructor and copy assignment 0a51fb22 Fix indentation c09a4cbb Add test cases for iterator to const iterator conversion 2d5f0c05 Redefine the converting assignment in iterator f2e16430 Add test cases for iterator to const iterator assignment c98169d0 Revert "Change iterator category to random access" 0f065edf Revert a change in reverse iterator to pass the test cases Ilya Polishchuk (1): a27dd3a6 enable_testing only if JSON_BuildTests is ON Itja (1): e423aea6 Typos README Jamie Seward (16): 5ec44fe9 Add /W4 for MSVS 19f8f1c0 Add missing "u8" 8a4af820 Fix warning C4706 8ba7f69a Fix whitespace af990907 Disable warning C4389: '==': signed/unsigned mismatch 917d9d8b Fix Visual Studio 2017 warnings a99fcb4e Add comments and newline 1a666799 Add string_view support 59cde1ad Fix for _HAS_CXX17 == 0 d468f8c4 Use consistent logic to determine if string_view exists 33c6511d Remove JSON_HAS_STRING_VIEW 73b1629a Remove tabs for spaces 16ffdbcb Remove c++17 support flag in cmake 6c9a401e Remove old non-perfect forwarding find and count 715c98b4 Remove extra spaces 992c836b Add missing spaces Jay Sistar (7): 31fe2f58 Adding support for Meson. 0719287e Reducing chatter about Meson. 87744fd5 Missed one. 6a656ed3 Adding first and second properties to iteration_proxy_internal d6c78dac Fixing assignement for iterator wrapper second, and adding unit test 00d841bf Adding equal and not equal operators to proxys. b78457b7 Making comparison operators const. Jorrit Wronski (2): b5ddd99a Updated hunter package links 7b8ddadd removed hunter badge Kaido (2): d0c9e5ff Allow overriding THROW/CATCH/TRY macros with no-exceptions (redo) ornladios#938 aed4a080 Templatize std::string in binary_reader ornladios#941 Krzysztof Woś (2): 86579209 Make exception base class visible in basic_json b9c3b8d6 Exit with an error if re2c is not available Kyle Thompson (1): 4b55f0eb To fix compilation issue for intel OSX compiler Lukas Barth (2): 40aff418 Pop for every push 0b1b6307 Also change the re2c file Markus Werle (1): 86b3d06a remove duplicate word Matthew K. Gumbel (1): 72bff90e 🔧 Fix up a few more effc++ items Matthias Möller (6): 5b4855de fix targetname 48d7a32d add .natvis for MSVC debug view af775ddb add compiler & cmake version check 8e9a8792 moved natis to root dir 24fe572d missing new line d1cda688 includes CTest module resp. BUILD_TESTING option Mike Bogdanov (5): daba1b6a fixed conformance with C++17, some members of allocator are depricated and should be used via allocator_traits 8890b935 fixed merge conflicts 64d6daa7 iter_impl template conformance with C++17 2a2ed799 pvs_studio fix. misprinted condition fd30ad8a did make amalgamate Nate Vargas (1): 727ee7d0 Set GENERATE_TAGFILE in Doxyfile Niels Lohmann (503): f1cd15ce ⚡ avoid copying a string d1b30250 ✅ added missing tests bf4d744d ✅ more tests for meta() call ae155c47 💄 cleanup bd0326cb ⚡ micro-optimizations for dump() b1441f34 ⚡ micro-optimizations for dump() 0f04e42d ⚡ micro-optimizations for dump() 909b439b ⚡ micro-optimizations for dump() 9c4919ff ⏪ "⚡ micro-optimizations for dump()" 54ef5f7b 🔨 moved serialization functions to serializer class af070744 🔨 integrating numtostr into serializer class fc48b8ac 🐛 fixed a logical error 224f9907 ⚡ micro-optimization of dump() 059f21aa 💄 fixed a warning d69242c6 💄 cleanup f84ac523 📝 added a note to ordered maps 6b3912d9 📝 added note to 3.0.0 wiki page ornladios#474 7b8fd864 🔥 removed deprecated constructor ornladios#480 c085e3ba 🔨 started with user-defined exceptions ornladios#301 ornladios#244 06815d27 🔨 added user-defined exceptions 104 and 105 01d3a006 ⬆️ updated Catch to v1.8.1 06c788e4 📝 added missing word b86d2148 🔨 added user-defined exceptions 106-108 776758d7 🔨 added user-defined exception 109 a1354184 📝 fixed typo ornladios#481 9381f6c4 🔨 added user-defined exceptions 201-202 875b2da9 🔨 added user-defined exceptions 203-204 a4274d77 🔨 added user-defined exceptions 205-206 0c40c8e3 🔨 added user-defined exceptions 2xx 068c7acd 🔨 added user-defined exceptions 301 f473f74f 🔨 added user-defined exceptions 303-304 aa842b4a 🔨 added user-defined exceptions 305 bb740c43 🔨 added user-defined exceptions 306 2a9393af 🔨 added user-defined exceptions 307 70b2c3f4 🔨 added user-defined exceptions 308 5cca44c1 🔨 added user-defined exceptions 309 144cf6a4 🔨 added user-defined exceptions 310 9e560ca4 🔨 added user-defined exceptions 313-315 6751d650 🔨 added user-defined exception 311 491c9780 🔨 added user-defined exception 311 60da36ae 🔨 added user-defined exceptions 401-402 30331fa2 🔨 added user-defined exception 403 38c2e20c added user-defined exceptions 404-405 a186106b 🔨 user-defined exception 302 21ec0e78 🔨 added user-defined exception 110 54073332 🔨 added user-defined exception 111 757d2c6c 🔨 replaced at() calls in msgpack/cbor 625cf7e3 🔨 added user-defined exception 112 8fcd0163 ✅ improved test coverage fc9b528e 🔨 changed an exception c8a6ce79 🚑 fixing fuzzers to work with new exceptions 9374eaa0 🔨 added user-defined exception 501 fe71e7df 📝 overworked documentation 1ab580d6 📝 more documentation for the new exceptions 0f6b8aa7 📝 more documentation for the new exceptions 758c4add 🚑 fix for ornladios#492 f5f6dac8 ✨ added overload for std::vector<bool> ornladios#494 f4126e4d ✨ added overload for std::less<value_t> ornladios#486 d9e2dd03 🔨 fixed interface for to_json function c7afb34e 🎨 cleanup after ornladios#496 65dfc97d 🔨 using __cpp_exceptions to detect exception support ornladios#498 e3e6cbec 🏁 added check for _CPPUNWIND 122afbf1 🔨 added defined() check 4e498298 🚑 fix for ornladios#493 4b9c2f12 🔨 added __EXCEPTIONS to the list 01470f38 👷 fixed no_exceptions test case e3e941ef 👷 fixed a syntax error 28dbe4e6 📝 overworked documentation for the at functions 80dcf22f 🔨 added a check function for MsgPack strings ornladios#497 87eafd8d ✅ added regression tests for ornladios#473 9355f058 🔨 cleaned up array from_json methods ornladios#473 8feaf8dc 💥 implemented new handling of NaN and INF ornladios#70 ornladios#329 ornladios#388 c5cf32e3 🔨 added user-defined exception 406 b8b4362c 🔥 removed accidentally committed binaries 84072fbd 💄 fixed indentation bfe4788e 🚑 fix for ornladios#500 b026591e 🚑 added special case to fuzzers to fix ornladios#504 95474e42 🏁 added parentheses around max/min calls ornladios#506 1de80e8a 🔨 added user-defined exception ornladios#493 710f8a26 📝 improved documentation for to-CBOR and to-msgpack functions 483a58f6 🚨 added pedantic flags for GCC c5711f30 🚧 a lot of minor changes cd43600e 💄 cleanup after ornladios#508 f547679d 🚑 fix for ornladios#516 and ornladios#518 31a6c091 🚑 fix for ornladios#519 d6085116 🚨 fixed a compiler warning ornladios#527 54db53c2 📝 update after ornladios#527 and ornladios#525 40160f48 🚧 manual lexer 3d597dda 📝 update after ornladios#534 20bcf101 📝 cleanup after ornladios#536 a58ed3cd 💄 cleanup cc36c65a 🚑 made exceptions nothrow-copy-constructible ornladios#531 c333679a 🔨 small refactoring cf778688 🔨 fixed check for is_nothrow_copy_constructible 53b501a7 🔨 cleanup 33361943 🔨 reverted changes that led to Travis failures 99e0d8b3 🔨 fixed \uxxxx parsing 3b069b4b 🔨 adjusted more expected exceptions 06e2a291 🔨 fixed number parsing 34255279 🔨 added code for locale-independent number parsing f75e195d 🔨 added code for user-defined number types b0c47abd 🔨 rewrote string parser to cope with UTF-8 bbb6bd9d 🔨 fixing last failing test cases 1e495945 🔨 fixed buffer overflow 6a6fbea6 🔨 some cleanup 50e251f5 🔨 adjusted test case to new signature of token_type_name() d37ca2eb 🔨 fixed test case a0aa6ad2 👷 added Xcode 8.3 19cd206d 📝 documented Xcode 8.3 6b12e404 🏁 removed __builtin_expect for MSVC 19d119e1 🔨 fixed a warning in MSVC 5d586b01 🔨 cleanup 62dfdf3f 📝 addressed ornladios#514 b4dbebff ✅ added regression test for ornladios#464 c2e80a72 🔨 deprecated j << istream / j >> ostream functions ornladios#367 60057a47 🔨 fixed bugs introduced by merging from develop d07596a0 📝 mentioned ornladios#540 and fixed ornladios#538 4c821c9e 🔨 moved buffer size to interface 50ee0a62 🔨 replaced lookup-tables by switches 3fa06108 🔨 added minibench to ignore list c32d2e5b 🔨 removed unget() function 3a5cf9bd 🔨 improved code coverage 89efe627 🔨 a lot of restructuring ea667db4 🔨 fixed compilation errors 782570d4 🔨 cleanup b15fc13d 🔨 implemented MessagePack in binary_reader c28bf823 🔨 added endianess check 08fdfcca 🔨 implemented a binary writer b992acc2 🔨 fixed a compiler warning ff72f388 🔨 fixed another warning 90273e93 🐛 fix for ornladios#512 97a25de9 ✨ proposal for ornladios#428 d4e49873 👷 experimenting with configurations 6f99d5b2 🔨 fixed test case 9d9c5216 👷 additional flags for MSVC ornladios#464 d3d87674 👷 fixed AppVeyor syntax 180d249f 👷 another try a9f40945 👷 another try c40c8ac9 👷 excluding MSVC 2015 with "/permissive- /std:c++latest /utf-8" 628be157 🐛 added fix for ornladios#464 e48114bb 🔨 check for value of _HAS_CXX17 186a9fd4 🔨 simplified interface for parser, lexer, and binary_reader f3e43d7c 🔨 some cleanup d7e57e3b 🔨 added an output adapter for the binary writer 5bea6f38 ✏️ fixed a typo ef556262 👷 added Clang 3.9-5.0 42b4cdd4 👷 Travis is very picky e2f6cf7f 🔥 removed .test files 951d0920 🐛 fixed README example 6b6e5540 🐛 added missing header aea47422 📝 updated links and output 717106ec 🔨 templated output_adapter and used in class serializer db9bf953 🔨 improved diagnostic output 9b32f725 📝 fixed examples for Wandbox e24df7ec 📝 improved documentation 4aedae40 ✅ added exhaustive UTF-8 tests 5febd04a 🐛 fixed test suite b686cc6a 🔨 removed #ifdefs 01e05d89 🔨 fixed a compiler warning 734297ff 🔨 cleanup 2df8f12c 🏁 another fix for MSVC ornladios#464 c42273d2 📝 fixed documentation ornladios#565 6d2c0a79 ✅ added more Unicode test cases cfc2e839 🔨 removed too long running tests 8b9f5117 ✨ started working on ornladios#458 19d2dec8 📝 added badge from isitmaintained.com ecf895f2 📝 mentioned value function on main doc page ornladios#570 fba1bcdd 🐛 fixing ornladios#575 962da001 ✨ implemented an indentation character ornladios#520 2afbd334 🔨 working on ornladios#367 978255da 📝 updated contribution guidelines 9b764ee5 🏁 fix for ornladios#581 723c8756 💬 replaced "backspace" with "backslash" ornladios#509 0c3ffe12 ⏪ reverting first/second experiment ornladios#350 99cb095e 🐛 fix for ornladios#586 9ddc69f3 🐛 adjusting fix for future versions ornladios#586 8a35fdd8 🔨 overworked accept() function 16b63d31 🔨 working toward ornladios#367 9e507dfa ✅ tests and fix for ornladios#367 c7bd01ed 🔨 trying something ornladios#367 9a576fe1 ✅ added test for ornladios#367 52adf3fd 🔨 fixed compilation c043ba69 🔥 removed failing test ornladios#529 d19c5ced 🐛 skipping BOM for iterators ornladios#602 1a9d7667 🐛 fixed the issue with GCC7 ornladios#590 92ef1969 ✏️ cleanup after ornladios#598 5fa5c17b ✏️ cleanup after ornladios#595 ac793e95 🔨 trying to fix ornladios#367 afb959a0 🔨 removed nonportable code 88dc7c11 🔨 fixed a warning b27d2adc ✨ accept functions to check if input is valid JSON ornladios#458 e1ca484b 📝 added note about Conan ornladios#566 889006f0 ✅ regression test for ornladios#600 1fbb82de 🔨 using std::array to buffer input b79a1a26 📝 update after ornladios#626 112a6f4e 🔨 replaced lexer's error message by const char* 70b7455a 🔨 minor change c2db4a11 👷 update Travis to use Ubuntu Trusty 14.04 images c2044205 📝 updated used compilers f2cdb3d5 ⬆️ Catch v1.9.5 82b95ca6 🔨 simplified error handling in parser e191dd83 🔨 fixed warning about pointer members 7c2a1872 ✅ improved test coverage a5c27ede 🔨 fixed a warning 2f007ca0 ✅ improved coverage 9add24ff 🔨 fixed a warning 84f2e64a ✅ improved coverage e7695306 🔨 fixed a warning 2fd214c1 🔨 adjusted pedantic flags 6f3bebff 🔨 removed unexpect function 4b543357 ✅ added progress output for Unicode tests b9a8425c 📝 cleanup after ornladios#629 and ornladios#630 e99b783d 🔨 simplifying scanner 32065c80 📝 fix for ornladios#639 8b123107 🔨 fixed some pedantic GCC warnings 07b78c99 🐛 fixed undefined behavior bug 63ecbfd3 ✅ re-added test df2feabb 👷 added Xcode 9 beta 015c8878 🔨 fixed a pedantic warning ac423337 ⬆️ Catch v1.9.6 6f12749e 📝 added version string for Xcode 9 566f6dcf 🔥 removing usused functions ornladios#645 55262234 📝 fixed typos b3ac36db 🔨 excluded uncovered lines b38ecb5c 🔨 simplified binary write 87bccbc3 🔨 removed exception parse_error.111 f697fec5 📝 fixed documentation 7b05e1a6 🔨 improved performance in dump for deeply nested values f1c543cb 👷 added GCC7 1b2fabe8 👷 adding two recent Clang versions 504012a3 📝 cleanup after ornladios#650 d3496347 👷 removing Clang 3.9 and 4.0 f1fabd1b 📄 added code of conduct 21d23982 🐛 fix for ornladios#656 a09193e9 🔨 cleanup 024fec8a 🔨 more cleanup using clang-tidy f513c467 🔨 further cleanup c7a69ae0 ⚡ started working on parser with provded result reference ornladios#418 d53ef950 🔨 fixed some warnings 5b5f0090 🔨 trying to fix the sanitizer error 18e0430b 🔨 adding destroy function to discard values 9b1c0588 🔨 reorganized interfaces for parse/accept functions ornladios#623 4414f94c 🔨 using input/output adapters for CBOR and MessagePack e6aa7003 🔨 cleanup 3d589fd0 🔨 fixed compilation error 669ebf51 🔨 fixed an error in MSVC 7d512140 ✨ implemented exception-free parser ornladios#458 ornladios#582 5851daa5 ✨ binary formats can be stored in std::string, std::ofstreams or std::ostringstream ornladios#477 c819a2d7 🔨 refactored some scanner internals 7737a295 🔨 small parser performance improvements 96dd4ffa 🔨 simplified a call 85c76808 🔨 using emplace 850d856a 🔨 cleanup after ornladios#663 e60002a1 🔨 fixed GCC warnings in ornladios#663 efdfd3aa ⚡ replaced by-value call ornladios#673 d1e13d51 🎉 first draft for ornladios#661 d2c35929 ✅ added test cases for update ornladios#661 e523312f ✅ improved test coverage 054b0250 👷 trying to install g++ to make clang work c90bf5e0 👷 removed failing builders 99ea12f3 📝 acknowledgements for ornladios#674, ornladios#678, ornladios#682, ornladios#685, and ornladios#686 c1642aff 👷 clang-3.8 eb6de822 👷 clang-3.7 e3335626 👷 different source e7a7e4f8 👷 fixed compiler 5aceb0e0 👷 clang-3.6 8963aae5 👷 clang-3.6 94dfecd4 👷 removed g++ c20dd752 👷 another try 3283352d 👷 using clang++ c06b5c5c 👷 clang-3.5 f256587c 👷 clang-3.4 82cd8c8d 👷 another try 6b20f6d1 👷 clang-3.8 e7f2d264 👷 removed gcc 195d773b 👷 added gcc 8de710bb 👷 added source for gcc 6dc89e47 👷 clang-3.9 e0f8eb17 👷 clang-4.0 f49356e7 👷 clang-3.4 5eb9f5fd 👷 clang-3.4 cd34358e 👷 removing clang from source 76b195d7 👷 fix for coverity + clang-5.0 bade3b3e 👷 cleanup 6151b056 🔨 cleanup 569c00eb 👷 changed c++17 to c++1z 7d19aed5 🔨 cleanup 08805f7f 🔨 cleanup fdff42bc 👷 forgot to install Cmake on OSX 76123fab 📝 added note wrt. ornladios#667 72afe53f 📝 updated documentation for update() function ornladios#661 1e360bb3 🔨 preparation for ornladios#505 df572aca 👷 set sanitizer to clang4 21726d8d 👷 run sanitizer after tests f5a53de8 👷 running sanitizer job in parallel 1f31a5b8 ⬆️ Catch v1.9.7 22b59693 💥 CBOR/MessagePack input must end with EOF ornladios#505 aba8b584 🔨 approach to un-break the changes for ornladios#462 c77a0be5 💥 changed iterators to andom_access_iterator ornladios#593 8acaf5bd 🚨 fixing two compiler warnings 64ef100e Revert ":boom: changed iterators to andom_access_iterator ornladios#593" ba5d37ba 👷 added Clang 5.0 (see https://docs.travis-ci.com/user/languages/cpp/#clang) e569b973 👷 trying to fix build error cd537909 👷 using Clang 5.0 41b2c69b 👷 using libc++ with Clang 9fd031b6 🐛 re-added support for std::valarray ornladios#702 0b5e8f85 🔨 cleanup e45eaf6e Revert ":construction_worker: using libc++ with Clang" c87b080c 👷 new cmake file for test cases 05b97c47 👷 added flags for Valgrind and Clang sanitizer 3dcd3601 👷 adding status messages 839681ff 👷 using Ninja 268f5a3d 👷 added option to switch off exceptions 5e7acbf0 👷 adjusted flags for Clang sanitizer 8608f421 👷 trying to use libstdc++ 4f5c3458 👷 run sanitizer another time to check if it works 0e94ba88 👷 using the same compilers 15e757c4 🔨 trying to fix memory issue with valarray b41b1304 👷 removed unneccessary test 91e00328 📝 improved documentation c607b5c2 📝 improved documentation da14286a 👷 try to use MSVC 2017 again 5c08b84d ⏪ back to previous MSVC 2017 fd250ae2 ✅ improved test coverage 9ae6796a ✅ improved test coverage b21d7810 ✅ improved test coverage fcba9ec5 🔨 clean up da97cf78 ✅ improved test coverage 74107637 ✅ improved test coverage e2e0ecd8 ✅ improved test coverage b90529c3 ✅ improved test coverage 737816d0 👷 another try with Travis 647711fa ✅ improved test coverage 1a66527d 📝 fixed documentation ornladios#745 8af49d4b 🚨 removing compiler warnings ornladios#755 1df836ce ⏪ removed call to std::signbit ornladios#761 8be303d4 🏁 fixing a min() call for MSVC ornladios#762 b91805e1 🚨 removing a compiler warning ornladios#755 7435d54e 🔨 clean up 3457e7bc 🏁 try to get MSVC 2017 running again a85bc358 🏁 another try e2045eae 🏁 and another try 5cb6d718 🚨 fixing last warning in ornladios#755 99ee4c1e 🔨 cleaned up Makefiles and docs ornladios#698 1b3df3a6 🔨 trying to use Coveralls with CMake ornladios#698 7b82e4b4 🔨 added Makefile target to calculate lcov coverage c204ac82 🔨 adjusted Coverity script to work without Makefile 75f4678b 🔨 added filter script for branch coverage 61536644 🔧 removing -Weffc++ warnings 73d1b55a 🔧 executing tests in parallel 60439aff 📝 different cmake call bab4a157 📝 comment how to integrate fifo_map (ornladios#485) 0c0851db 📝 comment how to integrate tsl::ordered_map (ornladios#546) d300a8e2 🚨 fixed warnings ornladios#776 24b6e028 ✅ improved test coverage f193427e 🔨 some simplifications b0c380b0 📝 cleanup after the last PRs 89650c99 🚧 checking if ornladios#714 is now fixed with MSVC 1b1bd0e3 ⏪ ornladios#714 is still not fixed c215b779 🚀 installed Stale Bot 7820b5ec 📝 thanks for ornladios#795 734e2b73 🔨 cleanup 61cc07ff 📝 some documentation cea3f24f 📝 comment to address ornladios#561 8e067c0c 🔨 set bidirectional iterator tag ornladios#593 fa1425b8 🚀 installed Sentiment Bot 6d2981db 📝 overworked templates c4d66267 🚀 installed Request Info Bot 5696660e 🔨 another try to fix ornladios#714 4c4f60f4 📝 fixes ornladios#820 de75cf89 ✅ improved test coverage 430f0351 🚨 fixed some warnings ornladios#821 cc937dea 🚑 the last commit contained a bug ornladios#821 25d205c1 📝 clarified difference between serialization and string value retrieval ornladios#853 9e2f185a 💄 reformatted code after PRs 7c2d4f18 👷 added Xcode 9.1 and 9.2 772bb3cc 📝 fixing documentation ornladios#867 7de009ed ✏️ fixing typos ornladios#869 569d275f 💥 throwing an exception in case dump encounters a non-UTF-8 string ornladios#838 8419bfbb ✅ improved test coverage a9a4ff61 🚨 remove C4996 warnings ornladios#872 e8d9963a 👌 cosmetic changes and overworked spelling 293748a9 📝 overworked README 920f64c0 ⬆️ updated to Catch 2.0.1 c6e7eae3 ✨ implemented JSON Merge Patch (RFC 7396) fb8482db 👌 fixed some issues from the last commit ornladios#875 9a70c60f Revert ":arrow_up: updated to Catch 2.0.1" 261caec2 👥 added contributor image c23f5dce 📝 fixed year 4c871c58 ✅ re-added tests for algorithms f3bd755c ➖ removing <iomanip> header 980795b6 ✏️ fixed typos 9a51fb4d 🚨 fixed some warnings 314e4e76 📝 improved documentation for dump and iterator_wrapper 9e3c4ad1 🔖 set version to 3.0.0 9eb5e2c2 🔖 set version to 3.0.0 106f9f54 ⬆️ updated git-update-ghpages script 1856f38c 📝 removed paragraph on version 3.0.0 88ddb12a 📝 fix for ornladios#883 3113a52a 📝 added exception 403 to documentation of at (ornladios#888) 3b3b6e8e 🚑 fix for ornladios#894 3c76ff35 📝 updated docs after PRs ebc6849b ✅ added test for ornladios#894 92484f0c 🔖 set version to 3.0.1 96b40b27 📝 fixed Doxygen warnings 78f8f837 added items() function ornladios#874 15b6421d ✅ added UTF-8 decoder capability and stress test c9938ea8 🚧 started UBJSON implementation 126ce2e5 🚧 further UBJSON 3d7658da 🚧 working on AppVeyor's errors ebf28a26 🚧 another try 97e0d20c 🚧 debug fb1154c2 🚧 debug fd049676 🐛 fixed copy-paste error 0a2920e0 ♻️ reorganized code ce53537b ➖ ➕ replaces amalgamation tool 85173f56 🔨 some clean up 965a70e3 🔨 optimized output format 31bfabc4 🔨 optimized input format 3a7585e7 ✅ added more tests 10bad938 🚧 added size benchmark for binary formats 241eea0c 📝 documentation f4a55f26 ➕ added amalgamate Python script a66b2d20 🚨 removed linter warnings for Python code 420dcf1f 🚧 added check whether code is amalgamated c772c01a ♻️ refactored code to split headers 541b4613 ♻️ adjusted code to split headers fea5f379 📝 it's 2018 411c16cb 📝 overworked documentation wrt. amalgamation ornladios#906 f85f4967 ✅ improved test coverage 06cddd37 🔨 removed failing amalgamation test 9d6b3731 ✅ improved test coverage 3ac67456 🔨 clean up 92f72950 🔨 cleanup b182308e 🔨 cleanup afe45713 🔨 cleanup + some noexcept 7456f1d8 ♻️ re-used existing UTF-8 decoder to simplfy string serialization a8f711a2 ➕ using Google Benchmark ornladios#921 b406e370 ➕ using Google Benchmark ornladios#921 3d776b05 📝 updated README 3cca6308 🔨 cleanup after ornladios#915 7eabb6ba 📝 updated documentation for UBJSON functions 3c68a796 🔥 deprecated iterator_wrapper ornladios#874 355c1e94 👷 added task to check amalgamation ornladios#906 1be3935e 📝 cleanup after ornladios#936 b0a68f54 ✅ added roundtrip tests for UBJSON f0b26c8f ✅ added fuzzer for UBJSON input 05f49fa4 ✅ added roundtrip tests for UBJSON 6855bbb9 🔨 split "parsing" directory to "input" and "output" 102c4743 🔨 clean up e95578f8 📝 documented JSON Merge Patch (RFC 7386) 1483d39c 🔨 moved class json_pointer into separate file ornladios#920 cb4a9c85 🔨 excluded code from coverage 52e94495 📝 added more functions to overview b3bd3b72 📝 added link to OSS-Fuzz project repository 8049442c 🔨 rename yytext to token_buffer (fixes ornladios#933) ce273af9 📝 added documentation for binary formats 57e6fddd 🚨 fixed warnings 51c774f2 📝 added documentation for binary formats 60e2d28e 🐛 fix for ornladios#947 552d1538 📝 added more statistics on binary formats e8bf1f62 ✨ added define for library version ornladios#948 ornladios#943 02584846 🔖 set version to 3.1.0 f5c03999 🔨 fixed benchmark compilation a8fcfd98 👷 fixed travis file b7796669 👷 re-added homebrew tests 5c2a0a51 👷 fixed coveralls 3a887dc9 👷 fixed coveralls 2b7b39c7 🚀 added release target ornladios#956 737cffe0 🔨 fixed directory for lcov coverage 8b457ace 🐛 fixing CBOR's indefinity length strings ornladios#961 33a9b00c 🐛 fix for ornladios#962 83db7876 🏁 removing test case that fails on MSVC ornladios#962 0111f318 🔨 working on ornladios#953 316634e1 🔨 added quotes around parameters 1e8f4d6a 🔨 more trying b455154c 🔨 another try ab05df3a 🔨 another try 74675dd6 ⏪ back to the original version 0a64982e 📝 cleanup after ornladios#954 865ff00d 📝 updated documentation wrt. objects ornladios#963 548f4889 🔨 overworked Makefile 61f0bfb1 🔨 enforce using Python 2 for the wandbox script 447f5421 🔨 overworked release target 94b7a8da 💄 fixed indentation 938c861a 🔖 set version to 3.1.1 8424d10e 🔖 set version to 3.1.1 1f3d2a3b 📝 overworked README 5773e164 🚨 fixed a linter warning 8d104e6f 💚 fixed test case 476b2e09 💚 added regression tests for ornladios#972 and ornladios#977 d2d65bb2 ♻️ refined SFINAE to fix some warnings d183d34b 💚 added another test case 38345fd0 👌 fixed some more warnings 97559bb1 🔨 trying to fix the leak cf60e18c 🔥 removing failing test (work on this in branch "leak") aa8fc2a4 🚑 hopefully fixed the memory leak 99185230 📝 cleanup after ornladios#1001 6151dfae 👌 made changes proposed in ornladios#1001 b56ac864 📝 thanks for ornladios#1006 8557151d ♻️ adjusting lexer/parser in symmetry to ornladios#1006 afef474c 🔖 set version to 3.1.2 8a6c8cb0 🔖 set version to 3.1.2 Nikita Ofitserov (7): 7b3cbfff Add some tests for std::move from std::initializer_list cf3ca3b7 Optimize json construction from rvalue string_t/array_t/object_t 09cda573 Support moving from rvalues in an std::initializer_list f5cae64e Update tests while fixing possible UB 0f4978e5 Fix an actually invalid test 897879bc Make detail::json_ref do less work by deferring moves/copies 93bb7123 Move from rvalues eagerly to work around MSVC problem Oleg Endo (4): f0ca96d4 include <iosfwd> instead of <iostream> b753cb6e use std::make_shared e3bb156f fix typo cd800522 Rename BuildTests to JSON_BuildTests Patrik Huber (3): 44b40d7c Fix links in README.md ae688016 Changed links from master to develop branch ee764365 Change to angle brackets Paul Fultz II (3): 34022609 Add a note about installing the library with cget 50863c5a Latest updates based on feedback 5731695d Clarify dev version and add space after the word flag. Perry Kundert (17): 90adf6ec Simplify get_token_string, unnecessary buffering, handle Byte Order Mark f585fe4e Test to confirm parsing of multiple JSON records in a istream ornladios#367 12efeadc Further simplify istream handling; use native unget 14ca1f6f Restore istream performance ornladios#764 o Use std::streambuf I/O instead of std::istream; does not maintain (unused) istream flags. o Further simplify get/unget handling. o Restore original handling of NUL in input stream; ignored during token_string escaping. 7c523338 Remove unnnecessary NUL termination of yytext (as it may contain NULs) 97a38880 Improve performance by constructing yytext as a std::string o Return its contents when necessary. In many cases, this avoids construction of multiple copies of the yytext token. Exceeds performance of current develop branch. e0d890cc Corrected unnnecessary const restriction on returned std::string 8665e259 Rename get_string to move_string to imply side-effect 546e148b Further performance improvements, and corrections in get_token_string o An (-'ve valued, typically -1) EOF must never be allowed in token_string, as it be converted to 255 -- a legitimate value. o Comparing against a specific eof() (-1, typically) is more costly than detecting +'ve/-'ve. Since EOF is the only non-positive value allowed we can use the simpler test. o Removed unnecessary test for token_string size, as it is already tested in the method, and must never occur in correct code; used an assert instead. f775922c Specify initializers for yytest, token_string using initializer-lists o We can retain -Weffc++ and specify default initializers by using initializer lists. The risks are low (of additional non-conformat compilers), because there is already one other such initialization used in the code-base. 184dab60 Accelerate access to underlying std::istream streambuf 1b43a45b Implement correct handling of std::streambuf int_type, eof() o Make no assumptions about eof(), other than that it is somewhere outside of the valid range of char_type. 5e480b56 Further simplify character type handling 45e1e3d4 Revert some unnecessary member initializer changes. 23440eb8 Remove outdated commentary about the value of eof(), retain input type o We assume the same character int_type as the unerlying std::istream o There are no assumptions on the value of eof(), other than that it will not be a valid unsigned char value. o To retain performance, we do not allow swapping out the underlying std::streambuf during our use of the std::istream for parsing. 0b803d0a Simplify the json/src/benchmarks.cpp to allow more optimal code gen. o For some unknown reason, the complexity of the benchmark platform prevented some C++ compilers from generating optimal code, properly reflective of the real performance in actual deployment. o Added the json_benchmarks_simple target, which performs the same suite of tests as json_benchmarks. o Simplified the benchmark platform, and emit an "Average" TPS (Transactions Per Second) value reflective of aggregate parse/output performance. a8cc7a1b Consistently use std::char_traits int_type-->char conversion intrinsics Ryan Mulder (3): 71597be2 add ensure_ascii parameter to dump. ornladios#330 40461c6c update comment on dump to not indicate that ensure_ascii is true by default 486f3a2d restore necessary comman in documentation of dump Sonu Lohani (1): 92da3348 Error : 'identifier "size_t" is undefined' in linux Steffen Brem (1): 04a1666e Add parentheses around std::min so it bypasses the macro introduced by windows.h. Ted Lyngmo (4): 9cfb777b Fix -Weffc++ warnings (GNU 6.3.1) 5b809b97 Fix -Weffc++ warnings (GNU 6.3.1) 70bbf195 Fix -Weffc++ warnings (GNU 6.3.1) cea24267 UTF8 encoding enhancement Théo DELRIEU (52): dbebf8de add to_json method for C arrays af9b2115 add enum class default conversions 85de93ba add std::pair<CompatibleStringType, T> support cea39dfa fix ornladios#600 c9836483 remove std::pair support 6e4910d5 add pair/tuple conversions 08d78105 add from_json support for std::array fe086d74 forward declare basic_json, add two macros a3321421 move json_pointer outside of basic_json 15625ca4 move input adapters outside of basic_json 8e681d1e move lexer/parser outside of basic_json 00d6e271 move primitive_iterator outside of basic_json 0ba98b6f move internal_iterator/iter_impl/iteration_proxy outside of basic_json bb752fd3 move json_reverse_iterator outside of basic_json acff23ef move binary_{reader,writer} outside of basic_json 8585d35c move serializer outside of basic_json bb1b4c93 fix from_json implementation for pair/tuple 4b46abf9 add forwarding references to json_ref constructor c9a02cbc to/from_json: add a MSVC-specific static_assert to force a stacktrace 541ee62a cmake: use BUILD_INTERFACE/INSTALL_INTERFACE in target_include_directories 5bffc957 add json_fwd.hpp d686713f add detail/macro_{un}scope.hpp f364f5ac add detail/meta.hpp 8c555db9 add detail/exceptions.hpp 7056b375 add detail/value_t.hpp e0c02c14 add detail/conversions/from_json.hpp 21881606 add detail/conversions/to_json.hpp 7ab3e8d7 add detail/parsing/input_adapters.hpp 3a0743db add detail/parsing/lexer.hpp 9ea25685 add detail/parsing/parser.hpp 51ecc31d add detail/iterators/primitive_iterator.hpp 3e65a652 add detail/iterators/internal_iterator.hpp bf06cf6c add detail/iterators/iter_impl.hpp 5fc9ef2b add detail/iterators/iteration_proxy.hpp ae6f6604 add detail/iterators/json_reverse_iterator.hpp 4dbb433a add detail/parsing/output_adapters.hpp d620f76f add detail/parsing/binary_reader.hpp c117515e add detail/parsing/binary_writer.hpp a3473fda add detail/serializer.hpp 8e9714fe add detail/json_ref.hpp 9cab30cf add adl_serializer.hpp 57d822b6 add missing includes, put back include comments 7e4ee23f add single_header CMake target 922b56e4 cmake: add back trailing slash to NLOHMANN_JSON_SOURCE_DIR 84bffd5d move amalgamate tool to third_party folder 5775084f cmake: add option to use/install the non-amalgamated version dcee778c fix sfinae on basic_json UDT constructor 14cd0198 fix cmake install directory (for real this time) 41db7cd8 Make the coveralls job use the multiple header version 01d61188 Fix constraints on from_json(CompatibleArrayType) c22f2d41 missing CHECK_NOTHROW in unit-udt 8711ec60 support construction from other basic_json types Tobias Hermann (1): ba231637 fix link to the documentation of the emplace function Vadim Evard (1): fc32b8a9 Fix a typo in README.md Vitaliy Manushkin (5): faccc37d dump to alternate implementation of string, as defined in basic_json template ed6b1464 dump to alternate implementation of string, as defined in basic_json template (changes to amalgamated code) 830f3e52 forward alternative string class from output_adapter to output_string_adapter 51349537 add unit test: checking dump to alternative string type 392c0338 test refactoring Vladimir Petrigo (1): 8edb0cd1 Add VS17 image to appveyor matrix WebProdPP (1): c9509ccf Update json.hpp Wilson (1): 05d3bf16 Make integration section concise abolz (10): 3ae82d91 Tests: Floating-point formatting uses lower case 'e' 107c21a4 Tests: Exponents are formatted with a leading '+' sign 6e2e466c Tests: Don't rely on the format used for floating-point formatting 68a97367 Tests: Re-enable some round-trip tests 0695ac40 Add tests for ornladios#360 332f3520 Add an implementation of the Grisu2 algorithm for binary to decimal floating-point conversion 9f7c2c04 Use the Grisu2 algorithm for formatting 'float's and 'double's 787204f0 Add unit-tests for detail::to_chars 810f81bb Regenerate src/json.hpp 9b9919d4 Use max_digits10 in dump_float for float->text->float round-trip dan-42 (3): f4349423 REFACTOR: rewrite CMakeLists.txt for better inlcude and reuse 966989a3 CONFIG: pin cmake to enable only C++ db0b9732 DOC: add sort mentioning about support in hunter gregmarr (1): ec60ff34 Add info for the vcpkg package. traits (2): ab44a50d Digraph warning 54c67dcf Update json.hpp zerodefect (2): d2b3fd15 Updated README.md to explain how installation of json_fwd.hpp can be achieved as part of install step. 95cf1fef Removed compiler warning about unused variable 'kMinExp'. 郭荣飞 (2): dfa371c4 fix doxygen error of basic_json::get() b8dff3bc remove the redundant @ref command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.