Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat short reads and writes in FilePOSIX #906

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Treat short reads and writes in FilePOSIX #906

merged 1 commit into from
Oct 3, 2018

Conversation

keichi
Copy link
Contributor

@keichi keichi commented Oct 2, 2018

Closes #905

@keichi keichi changed the title Treat short reads and writes in FilePOSIX WIP: Treat short reads and writes in FilePOSIX Oct 2, 2018
pnorbert
pnorbert reviewed Oct 2, 2018
View reviewed changes
Copy link
Contributor

@pnorbert pnorbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If writtenSize==-1 and errno is an interruption then the loop is invalid
buffer += writtenSize
size -= writtenSize

@keichi
Copy link
Contributor Author

keichi commented Oct 2, 2018

You're right, I will fix it.

@williamfgc
Copy link
Contributor

@keichi do stdio and fstream need this as well?

@keichi
Copy link
Contributor Author

keichi commented Oct 2, 2018

@pnorbert Please review.

@keichi
Copy link
Contributor Author

keichi commented Oct 2, 2018

@williamfgc Stdio and fstream works on Titan without any problem. I guess it's handling the short reads/writes internally.

@keichi keichi changed the title WIP: Treat short reads and writes in FilePOSIX Treat short reads and writes in FilePOSIX Oct 2, 2018
@williamfgc
Copy link
Contributor

@keichi interesting, this is great learning. Thanks!

@pnorbert pnorbert merged commit 69f69f1 into ornladios:master Oct 3, 2018
@keichi keichi deleted the fix-short-write branch October 3, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnorbert pnorbert pnorbert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keichi @williamfgc @pnorbert