Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are attributes supported with SST + FFS? #1006

Closed
keichi opened this issue Nov 19, 2018 · 4 comments
Closed

Are attributes supported with SST + FFS? #1006

keichi opened this issue Nov 19, 2018 · 4 comments

Comments

@keichi
Copy link
Contributor

keichi commented Nov 19, 2018

The heat transfer example in adiosvm/Tutorial/heat2d/cpp/ terminates with the following error when using SST engine and FFS marshaling:

gndx       = 100
gndy       = 100
rank 0 reads 2D slice 100 x 100 from offset (0,0)
ERROR: found null pointer in call to Attribute<T>::Data()

Usage: heatAnalysis  input  output N  M
  input:   name of input data file/stream
  output:  name of output data file/stream
  N:       number of processes in X dimension
  M:       number of processes in Y dimension

It seems that InquireAttribute() is returning an empty attribute object.

https://github.com/pnorbert/adiosvm/blob/872dfdb2d78bd3d932509d22e3b7e361ee6b0084/Tutorial/heat2d/cpp/analysis/heatAnalysis.cpp#L133-L134

Since the same workflow works with SST + BP, InSituMPI and BPFile, I think it is a problem with FFS marshaling.

@eisenhauer
Copy link
Member

eisenhauer commented Nov 19, 2018 via email

@keichi
Copy link
Contributor Author

keichi commented Nov 19, 2018

Got it, I found this out because JAXA is mainly using this workflow for testing. I can just comment out these lines for now.

@eisenhauer
Copy link
Member

eisenhauer commented Nov 19, 2018 via email

@eisenhauer
Copy link
Member

Attribute support for FFS marshaling has been merged to master. Currently FFS marshaling supports attributes to the extent that BP does, which is not completely. In particular, the support ignores the need to make attributes work (still be applied) even if timesteps are dropped, or a reader arrives late to a stream. That work is ongoing in SST, but I'll close this now as basic support is in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants