-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4305: Add support for Swahili translations (app strings and content) #4307
Conversation
The initial translations are being introduced in #4279 and the asset pipeline has already been updated.
Hi @anandwana001. PTAL at the whole PR as I plan to defer @vinitamurthi's review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Waiting for all the checks to pass.
Unassigning @anandwana001 since the review is done. |
Hi @BenHenning, it looks like some changes were requested on this pull request by @anandwana001. PTAL. Thanks! |
Hi @BenHenning, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Edit: The above is no longer true per the current plan. |
Note that any additional changes needed in this PR will be covered in #4345 as a fast-follow. Furthermore, @anandwana001's and @rt4914's reviews are being deferred (#4344 and #4266 are tracking each, respectively). Note that this does result in no approvals, but I've gotten confirmation from @seanlip as another technical representative that this is reasonable given the circumstances of getting these changes in quickly for an upcoming release. I'll make sure this PR does get reviewed post-submission. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks
Explanation
Fixes #4305
This PR introduces the base support for Swahili content and audio voiceover translations, and also registers Kenya as an accepted region by the app. #4279 is introducing the initial batch of app string translations, and the content pipeline has been updated to support importing Swahili translations. See the screenshot below for a reference.
Note that there aren't really any tests to add besides the manual verification.
Essential Checklist
For UI-specific PRs only
This PR is changing exactly one UI surface: support for Swahili. See this screenshot for reference:
Note that Swahili has exposed a few text overflow situations in the app but these are acceptable in the current alpha state of the app.