Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To review: PRs requiring Akshay approval #4344

Closed
2 tasks done
BenHenning opened this issue May 6, 2022 · 6 comments
Closed
2 tasks done

To review: PRs requiring Akshay approval #4344

BenHenning opened this issue May 6, 2022 · 6 comments
Assignees
@anandwana001
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented May 6, 2022 •
edited by anandwana001
Loading

The following PRs require post-merging PR approval from @anandwana001 :

Note that these were force-merged due to the sensitive timeline they're part of.

Reviewer: please review the above PRs & check them off once complete. Assign back to me once all have been addressed. Comments can be left directly on the original PRs, and I'll follow up with one PR to address all of them (if code changes are needed, otherwise I'll follow up on the corresponding PRs). This issue should only be closed once you're satisfied with all of the changes, including needed follow-up changes.
This was referenced May 6, 2022
Open
Merged
Merged
@BenHenning
Copy link
Member Author

@anandwana001 could you please review the above merged PRs per the instructions in the opening comment?

@anandwana001
Copy link
Contributor

Done

@anandwana001
Copy link
Contributor

Closing this issue as both the PRs I had reviewed and extra follow-up is needed.

@BenHenning
Copy link
Member Author

Closing this issue as both the PRs I had reviewed and extra follow-up is needed.

Sorry, to double check @anandwana001, did you mean to say that no extra follow-up is needed? Otherwise, I'd expect this issue to remain open until such items are addressed. Could you please clarify?

@anandwana001
Copy link
Contributor

Closing this issue as both the PRs I had reviewed and extra follow-up is needed.

Sorry, to double check @anandwana001, did you mean to say that no extra follow-up is needed? Otherwise, I'd expect this issue to remain open until such items are addressed. Could you please clarify?

I didn't saw any extra follow-up is required.

@BenHenning
Copy link
Member Author

Closing this issue as both the PRs I had reviewed and extra follow-up is needed.

Sorry, to double check @anandwana001, did you mean to say that no extra follow-up is needed? Otherwise, I'd expect this issue to remain open until such items are addressed. Could you please clarify?

I didn't saw any extra follow-up is required.

Thanks for confirming @anandwana001!

@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anandwana001 anandwana001

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenHenning @anandwana001