-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast-follow MR4 work items (writing tests) #4345
Comments
This needs to be bumped back to help expedite the initial beta release. |
Hi @BenHenning, PTAL, looks like all the TODOs here have been closed. |
Thanks @adhiamboperes. It does look like this can be closed now. |
The issue is reopened because of the following unresolved TODOs: Line 94 in 60b8034
oppia-android/app/src/main/java/org/oppia/android/app/databinding/TextViewBindingAdapters.java Line 47 in 60b8034
oppia-android/app/src/main/java/org/oppia/android/app/profile/ProfileChooserFragmentPresenter.kt Line 267 in 60b8034
Line 48 in 60b8034
oppia-android/utility/src/main/java/org/oppia/android/util/math/MathExpressionExtensions.kt Line 57 in 60b8034
|
Ah, it apparently isn't yet resolved @adhiamboperes. The above TODOs are what remains to address. |
This issue is tracking smaller work items that were intentionally postponed to expedite the MR4 release given tight scheduling and resourcing constraints. As a result, there may be cases when some tests weren't added. We should add those tests.
The open work items are tracked below:
Note: These work items were originally in this issue when it was first filed, but have since been closed (no further action is needed here):
Also, some PR descriptions also need to be updated. These are tracked separately in #5038.
The text was updated successfully, but these errors were encountered: