Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast-follow MR4 work items (writing tests) #4345

Open
5 tasks
BenHenning opened this issue May 6, 2022 · 5 comments
Open
5 tasks

Fast-follow MR4 work items (writing tests) #4345

BenHenning opened this issue May 6, 2022 · 5 comments
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented May 6, 2022

This issue is tracking smaller work items that were intentionally postponed to expedite the MR4 release given tight scheduling and resourcing constraints. As a result, there may be cases when some tests weren't added. We should add those tests.

The open work items are tracked below:


Note: These work items were originally in this issue when it was first filed, but have since been closed (no further action is needed here):

Also, some PR descriptions also need to be updated. These are tracked separately in #5038.

@BenHenning
Copy link
Member Author

This needs to be bumped back to help expedite the initial beta release.

@BenHenning BenHenning added Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 16, 2022
@BenHenning BenHenning removed this from the Beta MR2 milestone Sep 16, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_type_infrastructure labels Mar 28, 2023
@adhiamboperes
Copy link
Collaborator

Hi @BenHenning, PTAL, looks like all the TODOs here have been closed.

@BenHenning
Copy link
Member Author

Thanks @adhiamboperes. It does look like this can be closed now.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

The issue is reopened because of the following unresolved TODOs:

// TODO(#4345): Add tests to verify this behavior both for the study flag being on & off.


// TODO(#4345): Block on the following data provider before allowing the user to log in.


@BenHenning
Copy link
Member Author

BenHenning commented Apr 4, 2023

Ah, it apparently isn't yet resolved @adhiamboperes. The above TODOs are what remains to address.

@seanlip seanlip changed the title Fast-follow MR4 work items Fast-follow MR4 work items (writing tests) Jun 9, 2023
@MohitGupta121 MohitGupta121 added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Jun 16, 2023
@BenHenning BenHenning added this to the 1.0 Global availability milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

5 participants