Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3384: Arranged Help Activity string resources #3404

Closed
wants to merge 3 commits into from
Closed

Fix #3384: Arranged Help Activity string resources #3404

wants to merge 3 commits into from

Conversation

TheSwarnim
Copy link
Contributor

Explanation

Fixes #3384
In this PR, I've arranged HelpAcctivity string resources in the strings.xml file. I've also arranged FAQ string resources in a subheading of HelpActivity.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@TheSwarnim TheSwarnim requested a review from rt4914 as a code owner July 3, 2021 06:22
anandwana001
anandwana001 suggested changes Jul 3, 2021
View reviewed changes
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Show resolved Hide resolved
@TheSwarnim
Copy link
Contributor Author

@anandwana001 sir, please review it again. I've resolved the conversaton

anandwana001
anandwana001 approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

nit suggestion for future PR, the conversation must be resolved only by the PR reviewer.

@anandwana001 anandwana001 assigned rt4914 and unassigned TheSwarnim Jul 5, 2021
rt4914
rt4914 suggested changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSwarnim PTAL

app/src/main/res/values/strings.xml Outdated
@@ -449,4 +446,9 @@
<string name="correct_submitted_answer_with_append">Correct submitted answer: %s</string>
<string name="incorrect_submitted_answer">Incorrect submitted answer</string>
<string name="incorrect_submitted_answer_with_append">Incorrect submitted answer: %s</string>

<!-- Help Activity-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

  1. There should be space at the start.
  2. And there should be 1 space before and after text.

<!-- Help Activity -->

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks sir, I've done some changes in file, please review it again

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSwarnim It does not match with the above comment. Can you please take a look.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, update your branch by merging with latest develop.

@rt4914 rt4914 assigned TheSwarnim and unassigned rt4914 Jul 5, 2021
@anandwana001
Copy link
Contributor

@TheSwarnim any update on this?

@rishidyno
Copy link
Contributor

rishidyno commented Jul 24, 2021 •
edited
Loading

@anandwana001 I looked into help_activity.xml files no instances of string resources are being used in those files could you verify me if I am wrong.
Also, if @TheSwarnim is not working on this issue could it be assigned to me @anandwana001.

@anandwana001
Copy link
Contributor

@rishidyno The issue here is to arrange the resources which are used in the Help Screen (HelpActivity.kt, it's other related file) in strings.xml file.

Closing this PR and assigning to you @rishidyno

@aadityaguptaa aadityaguptaa mentioned this pull request Aug 30, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 requested changes

@anandwana001 anandwana001 anandwana001 approved these changes

Assignees

@TheSwarnim TheSwarnim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arrange string resources based on screens
4 participants
@TheSwarnim @anandwana001 @rishidyno @rt4914