Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3384: Arranged Help Activity string resources #3404

Closed
wants to merge 3 commits into from
Closed

Fix #3384: Arranged Help Activity string resources #3404

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9319c7f
Arranged Help Activity string resources
Jul 3, 2021
9dfac23
Arranged all Help Activity string resources in indentation
Jul 5, 2021
b7aea9b
resolved errors in Help Activity string resources
Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<string name="menu_home">Home</string>
<string name="menu_options">Options</string>
<string name="menu_my_downloads">My Downloads</string>
<string name="menu_help">Help</string>
<string name="exploration_activity_title">Exploration Player</string>
<string name="help_activity_title">Help</string>
TheSwarnim marked this conversation as resolved.
Show resolved Hide resolved
<string name="menu_switch_profile">Switch Profile</string>
Expand Down Expand Up @@ -52,13 +51,11 @@
<string name="topic_download_text">(%s)</string>
<string name="see_more">See More</string>
<string name="see_less">See Less</string>
<string name="FAQs">FAQs</string>
<string name="featured_questions">Featured Questions</string>
<string name="frequently_asked_questions">Frequently Asked Questions</string>
<string name="faq_activity_title">FAQs (Frequently Asked Questions)</string>
<string name="pin_password_activity_title">PIN verification</string>
<string name="onboarding_activity_title">Oppia Introduction</string>
<string name="frequently_asked_questions_FAQ">Frequently Asked Questions (FAQs)</string>
<string name="info">Info</string>
<string name="lessons">Lessons</string>
<string name="practice">Practice</string>
Expand Down Expand Up @@ -449,4 +446,10 @@
<string name="correct_submitted_answer_with_append">Correct submitted answer: %s</string>
<string name="incorrect_submitted_answer">Incorrect submitted answer</string>
<string name="incorrect_submitted_answer_with_append">Incorrect submitted answer: %s</string>

<!-- Help Activity-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

  1. There should be space at the start.
  2. And there should be 1 space before and after text.

<!-- Help Activity -->

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks sir, I've done some changes in file, please review it again

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSwarnim It does not match with the above comment. Can you please take a look.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, update your branch by merging with latest develop.

<string name="menu_help">Help</string>
<!-- FAQ (Help Activity)-->
TheSwarnim marked this conversation as resolved.
Show resolved Hide resolved
<string name="FAQs">FAQs</string>
<string name="frequently_asked_questions_FAQ">Frequently Asked Questions (FAQs)</string>
</resources>