-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrange string resources based on screens #3384
Comments
cc: @anandwana001 @rt4914 |
Hello @rt4914 @anandwana001, please assign this issue to me. I'm working on it |
Hello @anandwana001, Sir I've added a PR, please review it. |
@rishidyno Could you please comment here so that I can get your GitHub handle in the assignee section to assign this issue to you? |
@anandwana001 I would like to work on this issue. |
@anandwana001 can I work on this issue, please? |
Since there has been no PR from @rishidyno, so assigning this to @aadityaguptaa |
@aadityaguptaa Unassigning you from this issue because of inactivity, please re-assign yourself if you are currently working on this. |
I would like to work on this. |
Please assign this issue to me, I can solve this issue. @BenHenning @seanlip |
@Ayush-865, this issue is currently assigned to @MohitGupta121. Please take a look at #2399 instead. Generally, please only look at issues that are not assigned to anyone at the moment. |
@anandwana001 I would like to work on this issue. |
is this issue open to work ? |
@uphargaur, assigning this issue to you. To work on this, please do not change all the strings at once. Instead, please do 4-5 screens per PR. #5252 was the latest attempt to fix this issue, and is mostly the approach we are taking. |
update :- working on this ,getting some error to build , shared this on 5632 |
Describe the bug
Currently string resources are not organised correctly and are scattered in
strings.xml
file.This should be fixed by following these points:
Home
is part of multiple views likeNavigation Drawer
,Home-Toolbar
. So for this we should have separate strings for both.<!-- ProfileResetPinActivity -->
Arrange strings file as per below criteria:
Screen/Toolbar Titles
Used in manifest label, toolbar title and activity label test.
Pattern:
activity_name_activity_title
Example:
administrator_controls_activty_title
App Content Strings
Pattern:
activity_name_view_component_type
administrator_controls_activity_profile_management_label
administrator_controls_activity_account_actions_label
administrator_controls_activity_logout_item_text
administrator_controls_activity_app_version_item
Shared Strings
Pattern:
view_component_description
reading_text_size_item_text_small
reading_text_size_item_medium
Test Strings
Pattern:
test_file_name_view_component_type
Dialogs
Pattern:
dialog_name_view_component_type
Grouping Pattern:
<!-- AdministratorControlActivity -->
….
….
<!-- GeneralAvailabilityUpgradeNoticeDialogFragment -->
…..
<!-- ProgressDatabaseFullDialog -->
The text was updated successfully, but these errors were encountered: