Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3384 : Arranged string resources based on screens #4665

Closed
wants to merge 112 commits into from
Closed

Fix #3384 : Arranged string resources based on screens #4665

wants to merge 112 commits into from

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Oct 18, 2022

Explanation

Fix #3384 : Arranged string resources based on screens

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

MohitGupta121 and others added 30 commits May 25, 2022 12:47
@MohitGupta121 MohitGupta121 closed this by deleting the head repository Jan 3, 2023
@MohitGupta121
Copy link
Member Author

MohitGupta121 commented Jan 3, 2023

Actually I updating my fork branch as it's commit are ahead due to that I forget about this PR and this PR closed automatically as I delete my fork branch to rebase.

So I think I need to open new PR #4823 as now this PR is not updating with upstream branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrange string resources based on screens
2 participants