-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Improve installed package error when bundle can not be found #514
🌱 Improve installed package error when bundle can not be found #514
Conversation
@@ -47,7 +47,7 @@ func MakeInstalledPackageVariables( | |||
// find corresponding bundle for the installed content | |||
resultSet := catalogfilter.Filter(allBundles, catalogfilter.WithBundleImage(bundleImage)) | |||
if len(resultSet) == 0 { | |||
return nil, fmt.Errorf("bundleImage %q not found", bundleImage) | |||
return nil, fmt.Errorf("bundle with image %q not found in available catalogs but is currently installed via BundleDeployment %q", bundleImage, bundleDeployment.Name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@everettraven this is basically what you suggested here but with a slighlty modified message.
I'm trying to make an emphasis on the fact that the bundle is not fund in the currently available catalogs.
Let me know what you think.
P.S.: this PR will need a rebase after we merge #499.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
==========================================
+ Coverage 84.41% 84.43% +0.01%
==========================================
Files 23 23
Lines 892 893 +1
==========================================
+ Hits 753 754 +1
Misses 95 95
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
dd5eb77
to
004a748
Compare
004a748
to
0844b97
Compare
Signed-off-by: Mikalai Radchuk <[email protected]>
0844b97
to
4a94bc3
Compare
@grokspawn could you please take another look? PR got removed from a merge queue becuase #520 got merged and |
Checking CI signal, and then I'll approve again if green. |
Description
Follow up for #499 (comment)
Reviewer Checklist