-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Respect upgrade constraint policy set on Operator
#520
Merged
m1kola
merged 1 commit into
operator-framework:main
from
m1kola:add_upgradeConstraintPolicy
Nov 7, 2023
Merged
✨ Respect upgrade constraint policy set on Operator
#520
m1kola
merged 1 commit into
operator-framework:main
from
m1kola:add_upgradeConstraintPolicy
Nov 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Nov 6, 2023
m1kola
changed the title
✨ Add upgrade constraint policy
✨ Respect upgrade constraint policy set on Nov 6, 2023
Operator
m1kola
force-pushed
the
add_upgradeConstraintPolicy
branch
2 times, most recently
from
November 6, 2023 16:50
5b9e713
to
f1d4d8e
Compare
joelanford
reviewed
Nov 6, 2023
joelanford
reviewed
Nov 6, 2023
openshift-merge-robot
added
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Nov 6, 2023
m1kola
force-pushed
the
add_upgradeConstraintPolicy
branch
from
November 7, 2023 10:10
f1d4d8e
to
c7c44e6
Compare
openshift-merge-robot
removed
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Nov 7, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
+ Coverage 84.41% 84.45% +0.03%
==========================================
Files 23 23
Lines 892 907 +15
==========================================
+ Hits 753 766 +13
- Misses 95 96 +1
- Partials 44 45 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
m1kola
force-pushed
the
add_upgradeConstraintPolicy
branch
from
November 7, 2023 11:12
c7c44e6
to
7c27170
Compare
This commit makes OLM respect `.spec.upgradeConstraintPolicy` set on an `Operator` CR when chosing upgrade edges. Signed-off-by: Mikalai Radchuk <[email protected]>
m1kola
force-pushed
the
add_upgradeConstraintPolicy
branch
from
November 7, 2023 11:54
7c27170
to
2dea4fc
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Nov 7, 2023
joelanford
approved these changes
Nov 7, 2023
This was referenced Nov 7, 2023
Merged
via the queue into
operator-framework:main
with commit Nov 7, 2023
8c59a33
15 of 16 checks passed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #449
Reviewer Checklist