Ready For Review: in response to Automate Onboarding to Cluster via CLI #24

[Gregory-Pereira]

#24

[HumairAK]

@Gregory-Pereira first thing you should always do is make sure the make command works, in this case it doesn't:

$ make
go build -o opfcli-linux-amd64 -ldflags "-X 'github.com/operate-first/opfcli/version.BuildVersion=unknown' -X 'github.com/operate-first/opfcli/version.BuildHash=1ea33c3d36' -X 'github.com/operate-first/opfcli/version.BuildDate=2021-09-10T14:18:39'"
# github.com/operate-first/opfcli/models
models/OnboardClusterConfig.go:4:2: imported and not used: "fmt"
make: *** [Makefile:16: opfcli-linux-amd64] Error 2

There are a couple of compilation errors that you will find when you try to run this and fix the issues as they come.

(these are also illustrated in the review check failures)

[HumairAK]

@Gregory-Pereira the make still fails. See the checks above, and also try running it locally.

[HumairAK]

@Gregory-Pereira ci check still failing

[Gregory-Pereira]

Yeah, I need to build out and fix the test suite which I will complete this week. I will message you when it's done.

[Gregory-Pereira]

@HumairAK all tests pass, take a look when you can

[Gregory-Pereira]

Commits have been restructured, pre-commit passes for each individual commit (including test suites, make and the actual linting). Only unresolved suggestion (logging is awaiting review. @larsks Could you take a look at the commit structure / messages and see if that is clear enough? If not I can try to refactor again. We are aiming to get this merged by end of day Monday.

[harshad16]

Tested on my local , by build the binary from this pr.
it seems to be working well for the onboard
well done 🎖️
/lgtm

[4n4nd]

/lgtm

[HumairAK]

/lgtm
/approve

Amazing work @Gregory-Pereira !

[sesheta]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 4n4nd, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [HumairAK]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment