api tests pass

api/Onboard_test.go

@@ -1,17 +1,31 @@
 package api
 
-import "github.com/stretchr/testify/require"
+import (
+	"github.com/stretchr/testify/require"
+	"os"
+	"github.com/operate-first/opfcli/constants"
+	"path/filepath"
+)
 
-func (suite *apiTestSuite) TestOnboard() {
+func (suite *apiTestSuite) TestOnboardWithQuota() {
 	assert := require.New(suite.T())
 
-	err := suite.api.Onboard(
-		"./testdata/Onboard/sampleOnboardConfig.yaml",
+	err := os.MkdirAll(filepath.Join(
+		suite.api.RepoDirectory,
+		suite.api.AppName,
+		constants.ComponentPath,
+		"resourcequotas",
+		"testquota",
+	), 0755)
+	assert.Nil(err)
+
+	err = suite.api.Onboard(
+		"./testdata/Onboard/sampleOnboardConfigWithQuota.yaml",
 		"projectDisplayName",
 		false,
 	)
 	assert.Nil(err)
-	return 
+
 	expectedPaths := []string{
 		"cluster-scope/base/core/namespaces/testproject/kustomization.yaml",
 		"cluster-scope/base/core/namespaces/testproject/namespace.yaml",
@@ -23,3 +37,23 @@ func (suite *apiTestSuite) TestOnboard() {
 	compareWithExpected(assert, "testdata/Onboard", suite.dir, expectedPaths)
 }
 
+// func (suite *apiTestSuite) TestOnboardWithoutQuota() {
+// 	assert := require.New(suite.T())
+
+// 	err := suite.api.Onboard(
+// 		"./testdata/Onboard/sampleOnboardConfig.yaml",
+// 		"projectDisplayName",
+// 		false,
+// 	)
+// 	assert.Nil(err)
+
+// 	expectedPaths := []string{
+// 		"cluster-scope/base/core/namespaces/testproject/kustomizationWithoutQuota.yaml",
+// 		"cluster-scope/base/core/namespaces/testproject/namespace.yaml",
+// 		"cluster-scope/base/user.openshift.io/groups/testgroup/group.yaml",
+// 		"cluster-scope/components/project-admin-rolebindings/testgroup/kustomization.yaml",
+// 		"cluster-scope/components/project-admin-rolebindings/testgroup/rbac.yaml",
+// 	}
+
+// 	compareWithExpected(assert, "testdata/Onboard", suite.dir, expectedPaths)
+// }

api/testdata/Onboard/cluster-scope/base/core/namespaces/testproject/namespace.yaml

@@ -4,4 +4,4 @@ metadata:
     name: testproject
     annotations:
         openshift.io/requester: testgroup
-        openshift.io/display-name: test display name
+        openshift.io/display-name: projectDisplayName

api/testdata/Onboard/cluster-scope/base/user.openshift.io/groups/testgroup/group.yaml

@@ -0,0 +1,5 @@
+apiVersion: user.openshift.io/v1
+kind: Group
+metadata:
+    name: testgroup
+users: []

api/testdata/Onboard/cluster-scope/base/user.openshift.io/groups/testgroup/kustomization.yaml

@@ -0,0 +1,4 @@
+apiVersion: kustomize.config.k8s.io/v1beta1
+kind: Kustomization
+resources:
+    - group.yaml

api/testdata/Onboard/cluster-scope/components/project-admin-rolebindings/testgroup/kustomization.yaml

@@ -0,0 +1,4 @@
+apiVersion: kustomize.config.k8s.io/v1alpha1
+kind: Component
+resources:
+    - rbac.yaml

api/testdata/Onboard/cluster-scope/components/project-admin-rolebindings/testgroup/rbac.yaml

@@ -0,0 +1,12 @@
+apiVersion: rbac.authorization.k8s.io/v1
+kind: RoleBinding
+metadata:
+    name: namespace-admin-testgroup
+roleRef:
+    apiGroup: rbac.authorization.k8s.io
+    kind: ClusterRole
+    name: admin
+subjects:
+    - apiGroup: rbac.authorization.k8s.io
+      kind: Group
+      name: testgroup

api/testdata/Onboard/sampleOnboardConfigWithQuota.yaml

@@ -0,0 +1,12 @@
+env: Smaug
+namespaces:
+  - enable_monitoring: false
+    name: testproject
+    quota: testquota
+project_description: This is the configuration for a sample project / app to onboard
+target_cluster: Smaug
+team_name: testgroup
+template:
+users:
+  - [email protected]
+  - [email protected]

api/testdata/Onboard/sampleOnboardConfig.yaml → api/testdata/Onboard/sampleOnboardConfigWithoutQuota.yaml

@@ -2,7 +2,7 @@ env: Smaug
 namespaces:
   - enable_monitoring: false
     name: testproject
-    quota:
+    quota: 
 project_description: This is the configuration for a sample project / app to onboard
 target_cluster: Smaug
 team_name: testgroup