Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating the github-release tekton task #140

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

Gregory-Pereira
Copy link
Contributor

linting

Related Issues and Dependencies

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

in response to operate-first/opfcli#24
created automated git releases and populate those with artifacts.

Description

implements operate-first/opfcli#44 but pr from a feature branch.

@sesheta sesheta added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 16, 2021
@goern
Copy link
Member

goern commented Sep 23, 2021

/lgtm
nice work!

@harshad16 @Gregory-Pereira does it make sense to externalize all the python code in scripts and call them from the yaml? it would make all the things a little bit cleaner, so that we don't have a heavy mixture or Python and YAML code?!

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2021
@harshad16 harshad16 force-pushed the automated-git-release branch from 42ebcd9 to 7ab0a01 Compare November 6, 2021 21:04
@sesheta
Copy link
Contributor

sesheta commented Nov 6, 2021

New changes are detected. LGTM label has been removed.

@sesheta sesheta added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 6, 2021
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshad16 harshad16 merged commit f1b267f into AICoE:master Nov 6, 2021
@sesheta
Copy link
Contributor

sesheta commented Nov 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants