ztest -f option doesn't work

[wizeman]

In the Linux ZFS tree, we have this code in ztest_run_zdb():

4910         (void) sprintf(zdb,
4911             "%s/zdb/zdb -bcc%s%s -U /tmp/zpool.cache %s",
4912             bin,
4913             zopt_verbose >= 3 ? "s" : "",
4914             zopt_verbose >= 4 ? "v" : "",
4915             pool);

But in OpenSolaris, the code looks like this:

4754         (void) sprintf(bin,
4755             "/usr/sbin%.*s/zdb -bcc%s%s -U %s %s",
4756             isalen,
4757             isa,
4758             zopt_verbose >= 3 ? "s" : "",
4759             zopt_verbose >= 4 ? "v" : "",
4760             spa_config_path,
4761             pool);

As you can see, in the Linux repo, ztest calls zdb using a hardcoded path to /tmp/zpool.cache.

This makes it impossible to use the "-f" option of ztest, which is used for creating the test pool in a directory different than /tmp.

[behlendorf]

Thanks, I'll fix this up tomorrow. I'm sure I just didn't catch this when I did the last rebase to onnv_141. This code already needed to be fixed up once for Linux to remove the /usr/sbin/ part so ztest can run in-tree.

[behlendorf]

Honor spa_config_path for ztest '-f' option

The new spa_config_path string was lost from ztest_run_zdb() during
the onnv_141 merge. This commit puts it back in place so the '-f'
option is properly honored.

Additionally this function had been tweaked so ztest could be run
in-tree but that broke running it when installed as a package. I've
updated that chunk to detect where it's running and try to do the
right thing in both cases.

Closed by d24fbed