UCP: call user callback on ucp_ep_close_nbx. #6036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
petro-rudenko
force-pushed
the
ucp/ep-close-callback
branch
from
bf48833 to
b454d69
Compare
yosefe
reviewed
Dec 17, 2020
| @@ -806,6 +817,32 @@ UCS_TEST_P(test_ucp_wireup_2sided, connect_disconnect) { | |||
| } | |||
| } | |||
|
|
|||
| UCS_TEST_P(test_ucp_wireup_2sided, close_nbx_callback) { | |||
petro-rudenko
force-pushed
the
ucp/ep-close-callback
branch
from
b454d69 to
59680b5
Compare
yosefe
approved these changes
Dec 18, 2020
|
@tonycurtis can you pls take a look on small doc change? |
|
bot:pipe:retest |
petro-rudenko
force-pushed
the
ucp/ep-close-callback
branch
from
59680b5 to
cb5de58
Compare
|
Fixed |
|
iodemo (No traffic) /azp run |
|
bot:pipe:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use user passed params for
ucp_ep_flush_internalinucp_ep_close_nbxto handle callback and user data fields.Why ?
To unify ucp API, and makes easier to implement JUCX logic.