Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCP/EP: set callback on close request. #6081

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

petro-rudenko
Copy link
Member

What

Follow up on #6036 to get a completion callback on close request.

Why ?

To fix test hangs in JUCX NBX API #6067 since it doesn't call completion on close request

src/ucp/core/ucp_ep.c Outdated Show resolved Hide resolved
@petro-rudenko petro-rudenko force-pushed the ucp/set-callback-on-close-req branch 2 times, most recently from 189745d to f463350 Compare January 4, 2021 16:52
src/ucp/wireup/wireup_cm.h Outdated Show resolved Hide resolved
test/gtest/ucp/test_ucp_sockaddr.cc Outdated Show resolved Hide resolved
test/gtest/ucp/test_ucp_sockaddr.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@yosefe yosefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls squash

@petro-rudenko petro-rudenko force-pushed the ucp/set-callback-on-close-req branch from 57dffcf to 65b2fc5 Compare January 5, 2021 08:51
@petro-rudenko petro-rudenko force-pushed the ucp/set-callback-on-close-req branch from 65b2fc5 to 219a500 Compare January 5, 2021 10:30
@yosefe yosefe merged commit db9549d into openucx:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants