JUCX: add request status field. #6021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
reviewed
Dec 14, 2020
Comment on lines
25
to
29
| /** | ||
| * The only request that doesn't have automatic status update (no callback) | ||
| * so need to go into ucx to check it's real status | ||
| */ | ||
| private boolean isCloseRequest = false; |
There was a problem hiding this comment.
can we have CB on close as well, for consistency?
There was a problem hiding this comment.
Since there's no callback in ucp layer, we can't - since the user may not explicitly progress this request, but rely on the global progress thread, that just loops in progress.
There was a problem hiding this comment.
Will remove it after #6036
| updateRequestStatus(getNativeId()); | ||
| } | ||
|
|
||
| return (status != UcsConstants.STATUS.UCS_INPROGRESS); |
There was a problem hiding this comment.
It's safe to use the status field, since it's class private. getStatus will be inlined by JIT compiler at some point, but since this method is usually used in request progress loop, better to not rely on jit, IMO.
Comment on lines
10
to
11
| Java_org_openucx_jucx_ucp_UcpRequest_updateRequestStatus(JNIEnv *env, | ||
| jobject jucx_request, jlong ucp_req_ptr) |
There was a problem hiding this comment.
It's formatted by clang:
-JNIEXPORT void JNICALL
-Java_org_openucx_jucx_ucp_UcpRequest_updateRequestStatus(JNIEnv *env,
- jobject jucx_request, jlong ucp_req_ptr)
+JNIEXPORT void JNICALL Java_org_openucx_jucx_ucp_UcpRequest_updateRequestStatus(
+ JNIEnv *env, jobject jucx_request, jlong ucp_req_ptr)
{
jucx_request_update_status(env, jucx_request,
ucp_request_check_status((void *)ucp_req_ptr));
Let me fix, so it doesn't touch java
petro-rudenko
force-pushed
the
jucx/request-status
branch
from
ab06b46 to
0580ef0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add status field to UcpRequest class.
Why ?
To check the status of the request.
splitting from #6019