Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdns] move mDNS out of the commissioner library #53

Merged
merged 5 commits into from
Apr 21, 2020

Conversation

wgtdkp
Copy link
Member

@wgtdkp wgtdkp commented Mar 29, 2020

This PR moves discovery with mDNS out of the Commissioner library:

  • It is better for the mobile App/OS to use native mDNS service rather than the one provided by this library.
  • We still keep the borderagent discover command for the CLI App.

address issue: #51.
related issue: #31.

@wgtdkp wgtdkp requested review from bukepo and jwhui March 29, 2020 10:29
@codecov-io
Copy link

codecov-io commented Mar 30, 2020

Codecov Report

Merging #53 into master will increase coverage by 0.02%.
The diff coverage is 57.31%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   60.32%   60.35%   +0.02%     
==========================================
  Files          52       54       +2     
  Lines        5379     5277     -102     
==========================================
- Hits         3245     3185      -60     
+ Misses       2134     2092      -42     
Impacted Files Coverage Δ
include/commissioner/commissioner.hpp 100.00% <ø> (ø)
src/app/border_agent.hpp 100.00% <ø> (ø)
src/app/cli/interpreter.hpp 100.00% <ø> (ø)
src/app/commissioner_app.hpp 75.00% <ø> (ø)
src/app/file_logger.hpp 0.00% <0.00%> (ø)
src/app/json.hpp 0.00% <ø> (ø)
src/library/commissioner_impl.hpp 100.00% <ø> (ø)
src/library/commissioner_safe.cpp 62.20% <ø> (-1.57%) ⬇️
src/app/file_util.cpp 28.20% <28.20%> (ø)
src/app/border_agent.cpp 52.67% <52.67%> (ø)
... and 12 more

@wgtdkp wgtdkp linked an issue Apr 10, 2020 that may be closed by this pull request
@wgtdkp wgtdkp requested review from bukepo and removed request for bukepo April 18, 2020 10:01
src/app/cli/interpreter.hpp Show resolved Hide resolved
@jwhui jwhui added the enhancement New feature or request label Apr 21, 2020
@jwhui jwhui merged commit dda865b into openthread:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mdns] remove mDNS from the commissioner library to CLI App.
4 participants