Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdns] move mDNS out of the commissioner library #53

Merged
merged 5 commits into from
Apr 21, 2020
Merged

[mdns] move mDNS out of the commissioner library #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2507719
[mdns] move mDNS discovery out of the library
wgtdkp Mar 29, 2020
c410ec6
[test] fix integration tests
wgtdkp Mar 29, 2020
2b1f5c9
[test] update comments
wgtdkp Mar 29, 2020
ba28293
make pretty
wgtdkp Mar 30, 2020
2f0bf3e
rebase to master
wgtdkp Apr 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions include/commissioner/commissioner.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
#include <memory>
#include <string>

#include "border_agent.hpp"
#include "defines.hpp"
#include "error.hpp"
#include "network_data.hpp"
Expand Down Expand Up @@ -327,22 +326,6 @@ class Commissioner
*/
virtual void Stop() = 0;

/**
* @brief Asynchronously discover Thread Network at link-local.
*
* @param[in, out] aHandler A handler of the response and errors; Guaranteed to be called.
*/
virtual void Discover(Handler<std::list<BorderAgent>> aHandler) = 0;

/**
* @brief Synchronously discover Thread Network at link-local.
*
* @param[out] aBorderAgentList A list of discovered border agent.
*
* @return Error::kNone, succeed; otherwise, failed;
*/
virtual Error Discover(std::list<BorderAgent> &aBorderAgentList) = 0;

/**
* @brief Asynchronously connect to a Thread network.
*
Expand Down
4 changes: 4 additions & 0 deletions src/app/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ target_sources(commissioner-app
PRIVATE
commissioner_app.cpp
commissioner_app.hpp
border_agent.cpp
border_agent.hpp
file_logger.cpp
file_logger.hpp
file_util.cpp
Expand All @@ -45,6 +47,8 @@ target_link_libraries(commissioner-app
commissioner
commissioner-common
PRIVATE
fmt::fmt
mdns
nlohmann_json::nlohmann_json
)

Expand Down
Loading