-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move aliases of highway=track
from terms to aliases field
#470
Conversation
data/presets/highway/track.json
Outdated
"unmaintained", | ||
"woods road" | ||
"unmaintained road", | ||
"dirt road" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep terms sorted alphabetically. 🤓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize they were before. So, should I change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iD ranks terms by their position in the list, so sorting them alphabetically promotes some rarer terms over more common terms. This might be less of a problem now that some terms are aliases, but it’s hard to test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? Is this documented somewhere (+documented for translators)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, either I’m mistaken or it’s no longer in place. It looks like nowadays iD only considers the index of a match against the preset name but only filters by terms.
Well, the problem here is that this property was never documented (see ideditor/schema-builder#28), nobody really knows. The most conservative approach would be to use |
Yeah... I will answer in ideditor/schema-builder#28 |
(FYI I consider this blocked until ideditor/schema-builder#28 came to a conclusion) |
see ideditor/schema-builder#28 (comment) – please only keep |
9d3204d
to
49f529e
Compare
- add suggestions from @1ec5 - demote all except land-access road and track road to terms
Applied suggestions and #470 , ready for merge |
I would also have renamed the preset to
Land-Access Road
and movedTrack Road
to the aliases because with aliases, there is no need anymore to have any names with a/
but since you just implemented interpreting thealiases
field in iD, I guess you are aware of this possibility and had your reasons to keep it that way.See #288 (comment)