-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
describe the "aliases" property in the readme #28
Comments
Reopening, since the current description on the readme is still unsatisfactory. Some resources with background for this: |
This sounds reasonable. Both "Feldweg" and "Waldweg" should be an alias for "Feld-/Waldweg" as all "Feldweg"s and all "Waldweg"s are "Feld-/Waldweg"s (duh!). Trying to find an alias that 100% reflects "Feld-/Waldweg" and is not just a subset of it kind of defeats the possible usefulness of Though, it should be a strict subset of features represented by the preset that are not represented by a sub-preset. E.g. "wheelbender" can be an alias for However, the caveat to allow subsets is that if a sub-preset is created for a preset (like e.g. for bicycle parkings), some of the previously added aliases of the parent preset must be removed too (also from translations) which means it is more work. In the end, above all, the meaning and usefulness of |
Good point. A thing we could implement here (in addition to showing the alias in the list of search results, which is a great idea, btw) is to add an automated check which produces a warning when there exist any duplicate names or aliases between a preset and their sub-presets. |
This is a long list of aliases in some cases (example), especially if you merge the aliases from diffrerent dialects. Maybe you better only show them if one clicks on the i, together with the description from the data item. |
Sorry, I was a bit imprecise. I meant to only show the (single) alias which matches the user's search input (and only if the preset name doesn't match the search input). Very similar to how it is shown in the mock-up on openstreetmap/iD#6139 (comment) |
I'm tending towards only accept "real synonyms" as aliases. Apart from the already mentioned additional maintenance work of checking for potential duplicates in future sub-presets, there also exists the following additional issue if we allowed "subset names" which I find to be quite critical: When a search for a "subset name" matches a preset and the UI displays the sub-name alongside the preset's primary name, it can potentially give the impression to the mapper that the selected preset already fully describes the sub-preset they were thinking about. For example, assume we included "Oil Refinery" as an alias to the "Factory" preset. When a user searches for "oil factory", and iD would show the "Factory" preset (potentially displaying both names in the search result, for example like this: It would be very hard to convey in the user interface that some aliases are actual synonyms and others are special cases of what a preset can be used for. And that for the latter one should described the feature in more detail using the preset's fields or additional tags. I would say is that in many cases where one would be tempted to add a "subset name" to a preset as an alias, it is rather an indicator towards that a sub-preset is missing. For the cases where adding a sub-presets is impossible (e.g. because there are no tags to describe the sub-feature accurately), I think it is sufficient to continue to include these names as simple search terms. |
Hmm, the oil refinery / gold mine example seems to be a bit far fetched. You mean as alias for If no (strict) subset is allowed, e.g. the following wouldn't be possible as
Not necessarily. You know, it is possible to get ever more detailed about the (slightest nuances) in kind of places. Probably no synonym/alias is 100% a synonym, you'll always find that each word carries a slightly different nuance. That doesn't mean that this nuance must always be recorded and that it doesn't fit into the same box (=the same tag). |
But in any case, no work is lost and it is not an irreversible decision if you define |
See #3. This feature is currently not described in the project Readme.
The text was updated successfully, but these errors were encountered: