-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add MultiMaps extension to wikis #241
Conversation
6208302
to
8adb918
Compare
Have the issues discussed in the previous ticket been resolved? |
So is this creating two services or one? Is Where exactly does the API key need to go - is there a specific setting for it or do I just add it into the URL for the transport layer? |
In case of openstreetmap/operations#252: yes, in case of openstreetmap/operations#249: The problem was the use of composer, which is not used here.
This uses two tile layers. Historically, you could choose to have something like
There is no setting just add it into the URL, please. |
I've not seen usage on the private wikis I'm on. |
Thank you for adding the extension. Now we have version 0.7.2, but we need 0.7.3 (newest version) to include my addition to the code. I tried to implement this writing |
We always use the branch that corresponds to the mediawiki version we are running, both to ensure compatibility and to ensure we get updates as they are released. |
If you're sure that master will work with 1.31then we could consider it, or even update to 1.33 if necessary, but I'm reluctant because we will need to remember to change it back when the necessary edits make it to a release branch and I doubt we will... |
Actually 1.33 isn't released yet but 1.32 would be posssible. |
Can we please give the master branch a try? The extension's maintainer tried to backport the changes in Wikimedia Gerrit, but unfortunately there is no one with the capacity to merge the change for two weeks now (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MultiMaps/+/519538/; the code review is negative because the maintainer created an indentation error) and the backport would have copied the code from master to the other branches only anyway. |
I'm really reluctant because if we do that (a) we'll be tracking all upstream changes as they happen so things could break at any time and (b) we'll have to remember to change it back once there is a proper release. |
@pastakhov Can you help us here? |
Closes openstreetmap/operations#252 by adding MultiMaps to all wikis. The following steps are needed to finally replace unmaintained SlippyMap extension