Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "MultiMaps" extension to the main wiki #252

Closed
3 tasks done
Tigerfell opened this issue Nov 19, 2018 · 3 comments
Closed
3 tasks done

Adding "MultiMaps" extension to the main wiki #252

Tigerfell opened this issue Nov 19, 2018 · 3 comments
Labels
service:wiki The project wiki on wiki.openstreetmap.org

Comments

@Tigerfell
Copy link

Tigerfell commented Nov 19, 2018 •
edited
Loading

This is a follow-up to #249. The MultiMap extension allows the display of maps in MediaWiki using Leaflet (Link to MediaWiki's extension page).

The following points should be accessed before adding:

  • problems with composer: If I see it correctly, the requirements are defined in https://github.com/wikimedia/mediawiki-extensions-MultiMaps/blob/master/composer.json. Does it work with our configuration?
  • support of for an additional tile address using Leaflet: If the extension could support Transport tiles from thunderforest.com as well as the main style, it could replace the current slippy map completely, which is the goal.
    I could take care of this one if the composer configuration works.
  • disabling other map providers: straightforward setting change
@tomhughes
Copy link
Member

All of those composer requirements are dev only - there is nothing needed for ordinary run time deployments.

@Tigerfell
Copy link
Author

I opened a related ticket on Phabricator https://phabricator.wikimedia.org/T210033. No progress so far, I am waiting for a response from the extension's maintainer.

@pnorman pnorman added the service:wiki The project wiki on wiki.openstreetmap.org label Mar 3, 2019
wmfgerrit pushed a commit to wikimedia/mediawiki-extensions-MultiMaps that referenced this issue Jun 15, 2019
@Tigerfell @thiemowmde
Extension MultiMaps: Adding support for multiple URL in Leaflet
51f05f3 
This feature extension enables users to select one out of a given set of map tiles to display
on the wiki page (previously limited to tiles by OpenStreetMap). This will also make this
extension useful for the OpenStreetMap wiki (related issue: openstreetmap/operations#252).
I am not sure if my unit tests are sufficient as this is my first contribution to MediaWiki.

Bug: T210033
Change-Id: I0dcf4593e8811086cec31874d60880ba0c53b163
wmfgerrit pushed a commit to wikimedia/mediawiki-extensions that referenced this issue Jun 15, 2019
@pastakhov
Update git submodules
4f317f7 
* Update MultiMaps from branch 'master'
  to f72621b69d9fea25d2bf121d80812dcd23e7a9b9
  - Merge "Extension MultiMaps: Adding support for multiple URL in Leaflet"
  - Extension MultiMaps: Adding support for multiple URL in Leaflet
    
    This feature extension enables users to select one out of a given set of map tiles to display
    on the wiki page (previously limited to tiles by OpenStreetMap). This will also make this
    extension useful for the OpenStreetMap wiki (related issue: openstreetmap/operations#252).
    I am not sure if my unit tests are sufficient as this is my first contribution to MediaWiki.
    
    Bug: T210033
    Change-Id: I0dcf4593e8811086cec31874d60880ba0c53b163
@Tigerfell Tigerfell mentioned this issue Jun 15, 2019
Closed
4 tasks
@tomhughes
Copy link
Member

Fixed by openstreetmap/chef#241.

@openstreetmap-trac openstreetmap-trac mentioned this issue Jul 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
service:wiki The project wiki on wiki.openstreetmap.org
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add MultiMaps extension to wikis
3 participants
@tomhughes @pnorman @Tigerfell