Make NNCP optional #969
Merged
Make NNCP optional #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the the NNCP was already applied the user may wan to skip applying the network configuration policy.
hjensas
added a commit
to hjensas/ci-framework
that referenced
this pull request
Dec 9, 2024
Swtich the scenario to scenarios/centos-9/ironic.yml Update hooks/playbooks/control_plane_ironic.yml to include kustomization patches to configure ironic and Nova Cell with computeDriver: ironic.IronicDriver Depends-On: openstack-k8s-operators/install_yamls#969
hjensas
added a commit
to hjensas/ci-framework
that referenced
this pull request
Dec 9, 2024
Swtich the scenario to scenarios/centos-9/ironic.yml Update hooks/playbooks/control_plane_ironic.yml to include kustomization patches to configure ironic and Nova Cell with computeDriver: ironic.IronicDriver Depends-On: openstack-k8s-operators/install_yamls#969
hjensas
added a commit
to hjensas/ci-framework
that referenced
this pull request
Dec 9, 2024
Swtich the scenario to scenarios/centos-9/ironic.yml Update hooks/playbooks/control_plane_ironic.yml to include kustomization patches to configure ironic and Nova Cell with computeDriver: ironic.IronicDriver Depends-On: openstack-k8s-operators/install_yamls#969
|
/test install-yamls-deploy |
|
@hjensas: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hjensas, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 189e3dd
into
openstack-k8s-operators:main
4 of 5 checks passed
hjensas
added a commit
to hjensas/ci-framework
that referenced
this pull request
Dec 10, 2024
Swtich the scenario to scenarios/centos-9/ironic.yml Update hooks/playbooks/control_plane_ironic.yml to include kustomization patches to configure ironic and Nova Cell with computeDriver: ironic.IronicDriver Depends-On: openstack-k8s-operators/install_yamls#969
hjensas
added a commit
to hjensas/ci-framework
that referenced
this pull request
Dec 10, 2024
Swtich the scenario to scenarios/centos-9/ironic.yml Update hooks/playbooks/control_plane_ironic.yml to include kustomization patches to configure ironic and Nova Cell with computeDriver: ironic.IronicDriver Depends-On: openstack-k8s-operators/install_yamls#969
hjensas
added a commit
to hjensas/ci-framework
that referenced
this pull request
Dec 11, 2024
Swtich the scenario to scenarios/centos-9/ironic.yml Update hooks/playbooks/control_plane_ironic.yml to include kustomization patches to configure ironic and Nova Cell with computeDriver: ironic.IronicDriver Depends-On: openstack-k8s-operators/install_yamls#969
stuggi
added a commit
to stuggi/release
that referenced
this pull request
Dec 11, 2024
openstack-k8s-operators/install_yamls#969 changed the way when to apply NNCPs. As a result NNCPs were created for the kuttl jobs which is wrong. This sets the env vars to disable nmstate and nncp creation. Signed-off-by: Martin Schuppert <[email protected]>
Merged
karelyatin
added a commit
to karelyatin/install_yamls
that referenced
this pull request
Dec 11, 2024
[1] created new parameter for NNCP setup and now it explicitly require INSTALL_NNCP=false to be passed along with NETWORK_ISOLATION=false. restoring the previous behavior by using previous defaults relying on NETWORK_ISOLATION and NETWORK_BGP. [1] openstack-k8s-operators#969
openshift-merge-bot bot
pushed a commit
to openshift/release
that referenced
this pull request
Dec 11, 2024
openstack-k8s-operators/install_yamls#969 changed the way when to apply NNCPs. As a result NNCPs were created for the kuttl jobs which is wrong. This sets the env vars to disable nmstate and nncp creation. Signed-off-by: Martin Schuppert <[email protected]>
yingzhanredhat
pushed a commit
to yingzhanredhat/release
that referenced
this pull request
Dec 18, 2024
openstack-k8s-operators/install_yamls#969 changed the way when to apply NNCPs. As a result NNCPs were created for the kuttl jobs which is wrong. This sets the env vars to disable nmstate and nncp creation. Signed-off-by: Martin Schuppert <[email protected]>
yingzhanredhat
pushed a commit
to yingzhanredhat/release
that referenced
this pull request
Dec 24, 2024
openstack-k8s-operators/install_yamls#969 changed the way when to apply NNCPs. As a result NNCPs were created for the kuttl jobs which is wrong. This sets the env vars to disable nmstate and nncp creation. Signed-off-by: Martin Schuppert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the the NNCP was already applied the user may wan to skip applying the network configuration policy.